Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266662
Change subject: [WIP] Templatize Special:Contributions lines
......................................................................
[WIP] Templatize Special:Contributions lines
Bug: T122537
Change-Id: I11aac43de495881e10e393d075a231bd346ea547
---
M includes/specials/SpecialContributions.php
1 file changed, 24 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/62/266662/1
diff --git a/includes/specials/SpecialContributions.php
b/includes/specials/SpecialContributions.php
index 1a1b490..46c1f90 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -1095,16 +1095,13 @@
$userlink = '';
}
+ $flags = array();
if ( $rev->getParentId() === 0 ) {
- $nflag = ChangesList::flag( 'newpage' );
- } else {
- $nflag = '';
+ $flags[] = ChangesList::flag( 'newpage' );
}
if ( $rev->isMinor() ) {
- $mflag = ChangesList::flag( 'minor' );
- } else {
- $mflag = '';
+ $flags[] = ChangesList::flag( 'minor' );
}
$del = Linker::getRevDeleteLink( $user, $rev, $page );
@@ -1115,15 +1112,6 @@
$diffHistLinks = $this->msg( 'parentheses' )
->rawParams( $difftext .
$this->messages['pipe-separator'] . $histlink )
->escaped();
- $ret = "{$del}{$d}
{$diffHistLinks}{$chardiff}{$nflag}{$mflag} ";
- $ret .= "{$link}{$userlink} {$comment} {$topmarktext}";
-
- # Denote if username is redacted for this edit
- if ( $rev->isDeleted( Revision::DELETED_USER ) ) {
- $ret .= " <strong>" .
- $this->msg( 'rev-deleted-user-contribs'
)->escaped() .
- "</strong>";
- }
# Tags, if any.
list( $tagSummary, $newClasses ) =
ChangeTags::formatSummaryRow(
@@ -1131,7 +1119,27 @@
'contributions'
);
$classes = array_merge( $classes, $newClasses );
- $ret .= " $tagSummary";
+
+ $templateParams = array(
+ 'articleLink' => $link,
+ 'charDifference' => $chardiff,
+ 'classes' => $classes,
+ 'diffHistLinks' => $diffHistLinks,
+ 'flags' => implode( '', $flags ),
+ 'logText' => $comment,
+ 'revDeleteLink' => $del,
+ 'rev-deleted-user-contribs' => $revDeletedMsg,
+ 'tagSummary' => $tagSummary,
+ 'timestamp' => $d,
+ 'topmarktext' => $topmarktext,
+ 'userlink' => $userlink,
+ );
+
+ # Denote if username is redacted for this edit
+ if ( $rev->isDeleted( Revision::DELETED_USER ) ) {
+ $templateParams['rev-deleted-user-contribs'] =
+ $this->msg( 'rev-deleted-user-contribs'
)->escaped();
+ }
}
// Let extensions add data
--
To view, visit https://gerrit.wikimedia.org/r/266662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11aac43de495881e10e393d075a231bd346ea547
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
