Tim Landscheidt has uploaded a new change for review. https://gerrit.wikimedia.org/r/266935
Change subject: Tools: Fix argument quoting in jlocal ...................................................................... Tools: Fix argument quoting in jlocal Currently jlocal splits quoted arguments: | scfc@toolsbeta-cronrunner-02:~$ jlocal showargs "1 2" 3 | $VAR1 = [ | '1', | '2', | '3' | ]; | scfc@toolsbeta-cronrunner-02:~$ This change fixes this. In addition, it uses /bin/sh as the script does not use bash features and removes the comment that is not pertinent. Change-Id: I215d640160992028cb97e15b022c0cf007a41415 --- M modules/toollabs/files/jlocal 1 file changed, 2 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/35/266935/1 diff --git a/modules/toollabs/files/jlocal b/modules/toollabs/files/jlocal index f56e046..214eb4c 100644 --- a/modules/toollabs/files/jlocal +++ b/modules/toollabs/files/jlocal @@ -1,9 +1,3 @@ -#!/bin/bash +#!/bin/sh -# WAY too many things depend on this being run on a exec submit host -# This is used by tools that want to run a shell script that would -# launch jobs themselves. Since exec nodes are not submit nodes themselves -# and a lot of tools use this already, keep this up for now. Hopefully -# someone someday finds those tools, tells the authors to fix it up and -# then we can remove this. -exec $@ +exec "$@" -- To view, visit https://gerrit.wikimedia.org/r/266935 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I215d640160992028cb97e15b022c0cf007a41415 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
