Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/267029
Change subject: Alternative layout to I29f9a21
......................................................................
Alternative layout to I29f9a21
Change-Id: Iff1537ea719e6cae239332688df516cfe952b790
---
M resources/mobile.loggingSchemas/schemaMobileWebLanguageSwitcher.js
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/29/267029/1
diff --git a/resources/mobile.loggingSchemas/schemaMobileWebLanguageSwitcher.js
b/resources/mobile.loggingSchemas/schemaMobileWebLanguageSwitcher.js
index 6d7a11d..c3e7117 100644
--- a/resources/mobile.loggingSchemas/schemaMobileWebLanguageSwitcher.js
+++ b/resources/mobile.loggingSchemas/schemaMobileWebLanguageSwitcher.js
@@ -1,18 +1,27 @@
( function ( M ) {
var context = M.require( 'mobile.context/context' ),
- samplingRate = mw.config.get(
'wgMFSchemaMobileWebLanguageSwitcherSampleRate', {} ),
+ samplingRates = mw.config.get(
'wgMFSchemaMobileWebLanguageSwitcherSampleRate', {} ),
ignoreSamplingRate = mw.config.get(
'wgMFIgnoreEventLoggingBucketing' ),
schemaMobileWebLanguageSwitcher = {};
- if ( mw.eventLog ) {
- if ( ignoreSamplingRate ) {
- samplingRate = 1;
- } else {
- samplingRate = ( context.isBetaGroupMember() ?
samplingRate.beta : samplingRate.stable ) || 0;
+ function getSamplingRate() {
+ var result;
+
+ if (ignoreSamplingRate) {
+ return 1;
}
+
+ result = context.isBetaGroupMember()
+ ? samplingRate.beta
+ : samplingRate.stable;
+
+ return result || 0;
+ }
+
+ if ( mw.eventLog ) {
schemaMobileWebLanguageSwitcher = new mw.eventLog.Schema(
'SchemaMobileWebLanguageSwitcher',
- samplingRate,
+ getSamplingRate(),
{
// throwing in the timestamp to have a better
chance of being unique ;)
funnelToken: mw.user.generateRandomSessionId()
+ new Date().getTime(),
--
To view, visit https://gerrit.wikimedia.org/r/267029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff1537ea719e6cae239332688df516cfe952b790
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <g...@samsmith.io>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
