[MediaWiki-commits] [Gerrit] build: Actually check that all required files are not missing - change (oojs/ui)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: build: Actually check that all required files are not missing
......................................................................


build: Actually check that all required files are not missing

Previously, you could `rm src/themes/mediawiki/MediaWikiTheme.js`,
and the build would happily pass.

Change-Id: I1c5041957202459f32529ce6e5d60159803a13f5
---
M Gruntfile.js
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index 7701198..14794d6 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -8,7 +8,7 @@
                pkg = grunt.file.readJSON( 'package.json' ),
                lessFiles = {},
                colorizeSvgFiles = {},
-               requiredFiles = modules[ 'oojs-ui' ].scripts.slice(),
+               requiredFiles = [],
                concatCssFiles = {},
                rtlFiles = {},
                lessTarget = grunt.option( 'graphics' ) || 'mixed',
@@ -34,6 +34,14 @@
        grunt.loadNpmTasks( 'grunt-karma' );
        grunt.loadNpmTasks( 'grunt-svg2png' );
        grunt.loadTasks( 'build/tasks' );
+
+       ( function () {
+               var module;
+               for ( module in modules ) {
+                       requiredFiles.push.apply( requiredFiles, modules[ 
module ].scripts || [] );
+                       requiredFiles.push.apply( requiredFiles, modules[ 
module ].styles || [] );
+               }
+       }() );
 
        ( function () {
                var distFile, module, moduleStyleFiles;
@@ -74,7 +82,6 @@
                for ( module in modules ) {
                        if ( modules[ module ].styles ) {
                                moduleStyleFiles = modules[ module ].styles;
-                               requiredFiles.push.apply( requiredFiles, 
moduleStyleFiles );
 
                                distFile = 'dist/' + module + '.css';
 

-- 
To view, visit https://gerrit.wikimedia.org/r/267027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c5041957202459f32529ce6e5d60159803a13f5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits