Dduvall has uploaded a new change for review.
https://gerrit.wikimedia.org/r/267181
Change subject: QA: Fix user lookup test for Linux Firefox
......................................................................
QA: Fix user lookup test for Linux Firefox
The form submit button was not actually being clicked due to
interference from the username autocomplete dropdown. This seems to only
be an issue in Firefox on Linux but is easily worked around by adding an
enter key press after filling in the username.
Change-Id: I11f3284496381bb3870dd8a71e067209d5a0dc2a
---
M Gemfile.lock
M tests/browser/features/support/pages/special_central_auth.rb
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth
refs/changes/81/267181/1
diff --git a/Gemfile.lock b/Gemfile.lock
index 5a2756f..bd68341 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -99,3 +99,6 @@
DEPENDENCIES
mediawiki_selenium (~> 1.6.3)
rubocop (~> 0.34.1)
+
+BUNDLED WITH
+ 1.10.6
diff --git a/tests/browser/features/support/pages/special_central_auth.rb
b/tests/browser/features/support/pages/special_central_auth.rb
index cbd4068..9f35ef7 100644
--- a/tests/browser/features/support/pages/special_central_auth.rb
+++ b/tests/browser/features/support/pages/special_central_auth.rb
@@ -9,7 +9,7 @@
fieldset(:centralauth_info, id: 'mw-centralauth-info')
def lookup_user(username)
- target_field_element.when_present.send_keys(username)
+ target_field_element.when_present.send_keys(username, :enter)
submit_element.when_present.click
end
end
--
To view, visit https://gerrit.wikimedia.org/r/267181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11f3284496381bb3870dd8a71e067209d5a0dc2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Dduvall <dduv...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
