Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/267249
Change subject: Use PHPUnit_Framework_TestCase in WikibaseLib tests ...................................................................... Use PHPUnit_Framework_TestCase in WikibaseLib tests where possible and we have no good reason to need to use MediaWikiTestCase. Change-Id: Iad3bdcf59043310681d98a91c527d66a6bb83cca --- M lib/tests/phpunit/DataTypeDefinitionsTest.php M lib/tests/phpunit/MediaWikiContentLanguagesTest.php M lib/tests/phpunit/StaticContentLanguagesTest.php M lib/tests/phpunit/StringNormalizerTest.php M lib/tests/phpunit/TermIndexEntryTest.php M lib/tests/phpunit/UnionContentLanguagesTest.php 6 files changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/49/267249/1 diff --git a/lib/tests/phpunit/DataTypeDefinitionsTest.php b/lib/tests/phpunit/DataTypeDefinitionsTest.php index c4aed4e..592ed6f 100644 --- a/lib/tests/phpunit/DataTypeDefinitionsTest.php +++ b/lib/tests/phpunit/DataTypeDefinitionsTest.php @@ -2,6 +2,7 @@ namespace Wikibase\Lib\Tests; +use PHPUnit_Framework_TestCase; use Wikibase\Lib\DataTypeDefinitions; /** @@ -14,7 +15,7 @@ * @licence GNU GPL v2+ * @author Daniel Kinzler */ -class DataTypeDefinitionsTest extends \MediaWikiTestCase { +class DataTypeDefinitionsTest extends PHPUnit_Framework_TestCase { private function getDefinitions() { return array( diff --git a/lib/tests/phpunit/MediaWikiContentLanguagesTest.php b/lib/tests/phpunit/MediaWikiContentLanguagesTest.php index 730180e..d31035e 100644 --- a/lib/tests/phpunit/MediaWikiContentLanguagesTest.php +++ b/lib/tests/phpunit/MediaWikiContentLanguagesTest.php @@ -2,7 +2,7 @@ namespace Wikibase\Lib\Test; -use MediaWikiTestCase; +use PHPUnit_Framework_TestCase; use Wikibase\Lib\MediaWikiContentLanguages; /** @@ -14,7 +14,7 @@ * @license GNU GPL v2+ * @author Marius Hoch < h...@online.de > */ -class MediaWikiContentLanguagesTest extends MediaWikiTestCase { +class MediaWikiContentLanguagesTest extends PHPUnit_Framework_TestCase { public function testGetLanguages() { $wbContentLanguages = new MediaWikiContentLanguages(); diff --git a/lib/tests/phpunit/StaticContentLanguagesTest.php b/lib/tests/phpunit/StaticContentLanguagesTest.php index e364c55..4e21e4f 100644 --- a/lib/tests/phpunit/StaticContentLanguagesTest.php +++ b/lib/tests/phpunit/StaticContentLanguagesTest.php @@ -2,6 +2,7 @@ namespace Wikibase\Lib\Test; +use PHPUnit_Framework_TestCase; use Wikibase\Lib\StaticContentLanguages; /** @@ -13,7 +14,7 @@ * @license GNU GPL v2+ * @author Adrian Heine < adrian.he...@wikimedia.de > */ -class StaticContentLanguagesTest extends \MediaWikiTestCase { +class StaticContentLanguagesTest extends PHPUnit_Framework_TestCase { /** * @dataProvider provideTestGetLanguages diff --git a/lib/tests/phpunit/StringNormalizerTest.php b/lib/tests/phpunit/StringNormalizerTest.php index 8e078d9..feb6859 100644 --- a/lib/tests/phpunit/StringNormalizerTest.php +++ b/lib/tests/phpunit/StringNormalizerTest.php @@ -2,6 +2,7 @@ namespace Wikibase\Test; +use PHPUnit_Framework_TestCase; use Wikibase\StringNormalizer; /** @@ -14,7 +15,7 @@ * @author John Erling Blad < jeb...@gmail.com > * @author Daniel Kinzler */ -class StringNormalizerTest extends \MediaWikiTestCase { +class StringNormalizerTest extends PHPUnit_Framework_TestCase { /** * @dataProvider providerTrimBadChars diff --git a/lib/tests/phpunit/TermIndexEntryTest.php b/lib/tests/phpunit/TermIndexEntryTest.php index 3ad5c85..f2068eb 100644 --- a/lib/tests/phpunit/TermIndexEntryTest.php +++ b/lib/tests/phpunit/TermIndexEntryTest.php @@ -2,6 +2,7 @@ namespace Wikibase\Test; +use PHPUnit_Framework_TestCase; use Wikibase\DataModel\LegacyIdInterpreter; use Wikibase\DataModel\Term\Term; use Wikibase\TermIndexEntry; @@ -16,7 +17,7 @@ * @licence GNU GPL v2+ * @author Daniel Kinzler <daniel.kinz...@wikimedia.de> */ -class TermIndexEntryTest extends \MediaWikiTestCase { +class TermIndexEntryTest extends PHPUnit_Framework_TestCase { public function provideConstructor() { return array( diff --git a/lib/tests/phpunit/UnionContentLanguagesTest.php b/lib/tests/phpunit/UnionContentLanguagesTest.php index c22a34d..1d35288 100644 --- a/lib/tests/phpunit/UnionContentLanguagesTest.php +++ b/lib/tests/phpunit/UnionContentLanguagesTest.php @@ -2,6 +2,7 @@ namespace Wikibase\Lib\Test; +use PHPUnit_Framework_TestCase; use Wikibase\Lib\ContentLanguages; use Wikibase\Lib\UnionContentLanguages; @@ -14,7 +15,7 @@ * @license GNU GPL v2+ * @author Adrian Heine < adrian.he...@wikimedia.de > */ -class UnionContentLanguagesTest extends \MediaWikiTestCase { +class UnionContentLanguagesTest extends PHPUnit_Framework_TestCase { /** * @dataProvider provideTestGetLanguages -- To view, visit https://gerrit.wikimedia.org/r/267249 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad3bdcf59043310681d98a91c527d66a6bb83cca Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits