Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/267258
Change subject: Remove use of SnakFactory in
WikibaseDataAccessTestItemSetUpHelper
......................................................................
Remove use of SnakFactory in WikibaseDataAccessTestItemSetUpHelper
SnakFactory is deprecated and don't think use of it was
really so helpful here.
Change-Id: Id6cecd3a7a05469b14e0ad2e7cf76f4029183513
---
M
client/tests/phpunit/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php
1 file changed, 7 insertions(+), 20 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/58/267258/1
diff --git
a/client/tests/phpunit/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php
b/client/tests/phpunit/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php
index ac147b3..a5c6321 100644
---
a/client/tests/phpunit/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php
+++
b/client/tests/phpunit/includes/DataAccess/WikibaseDataAccessTestItemSetUpHelper.php
@@ -12,11 +12,11 @@
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\SiteLink;
use Wikibase\DataModel\SiteLinkList;
+use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Snak\Snak;
use Wikibase\DataModel\Snak\SnakList;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
-use Wikibase\SnakFactory;
use Wikibase\Test\MockClientStore;
use Wikibase\Test\MockRepository;
@@ -54,7 +54,7 @@
$stringProperty = $this->getTestProperty( new PropertyId(
'P342' ), 'string', 'LuaTestStringProperty' );
$itemProperty = $this->getTestProperty( new PropertyId( 'P456'
), 'wikibase-item', 'LuaTestItemProperty' );
- $stringSnak = $this->getTestSnak(
+ $stringSnak = new PropertyValueSnak(
$stringProperty->getId(),
new StringValue( 'Lua :)' )
);
@@ -62,15 +62,15 @@
$statement1 = $this->getTestStatement( $stringSnak );
$statement1->setRank( Statement::RANK_PREFERRED );
- $qualifierSnak1 = $this->getTestSnak(
+ $qualifierSnak1 = new PropertyValueSnak(
new PropertyId( 'P342' ),
new StringValue( 'A qualifier Snak' )
);
- $qualifierSnak2 = $this->getTestSnak(
+ $qualifierSnak2 = new PropertyValueSnak(
new PropertyId( 'P342' ),
new StringValue( 'Moar qualifiers' )
);
- $referenceSnak = $this->getTestSnak(
+ $referenceSnak = new PropertyValueSnak(
new PropertyId( 'P342' ),
new StringValue( 'A reference' )
);
@@ -85,7 +85,7 @@
$this->siteLinkLookup->putEntity( $stringProperty );
$this->siteLinkLookup->putEntity( $itemProperty );
- $stringSnak2 = $this->getTestSnak(
+ $stringSnak2 = new PropertyValueSnak(
$stringProperty->getId(),
new StringValue( 'Lua is clearly superior to the parser
function' )
);
@@ -93,7 +93,7 @@
$statement2 = $this->getTestStatement( $stringSnak2 );
$statement2->setRank( Statement::RANK_NORMAL );
- $itemSnak = $this->getTestSnak(
+ $itemSnak = new PropertyValueSnak(
$itemProperty->getId(),
new EntityIdValue( new ItemId( 'Q885588' ) )
);
@@ -164,19 +164,6 @@
$this->siteLinkLookup->putEntity( $item );
return $item;
- }
-
- /**
- * @param PropertyId $propertyId
- * @param DataValue $value
- *
- * @return Snak
- */
- private function getTestSnak( PropertyId $propertyId, DataValue $value
) {
- $snakFactory = new SnakFactory();
- $snak = $snakFactory->newSnak( $propertyId, 'value', $value );
-
- return $snak;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/267258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6cecd3a7a05469b14e0ad2e7cf76f4029183513
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
