Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/267396

Change subject: ruthenium: slight syntax change for require_package
......................................................................

ruthenium: slight syntax change for require_package

We got a puppet error, undefined method `function_create_resources' ,
and i want to see if this changes it. This syntax is what we use
in another place already to install multiple packages.

Change-Id: Ie5d175566eac35e0c7754a60c15c27e15a54a85a
---
M modules/visualdiff/manifests/init.pp
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/96/267396/1

diff --git a/modules/visualdiff/manifests/init.pp 
b/modules/visualdiff/manifests/init.pp
index 32d38b2..2099be6 100644
--- a/modules/visualdiff/manifests/init.pp
+++ b/modules/visualdiff/manifests/init.pp
@@ -2,14 +2,17 @@
 #
 # This module provides a standalone visual diffing service.
 class visualdiff {
-    require_package([
+
+    $visualdiff_packages = [
         'nodejs',
         'npm',
         # These are required to build uprightdiff.
         # They can be skipped once we get a packaged version # from elsewhere.
         'build-essential',
         'g++',
-    ])
+    ]
+
+    require_package($visualdiff_packages)
 
     group { 'visualdiff':
         ensure => present,

-- 
To view, visit https://gerrit.wikimedia.org/r/267396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5d175566eac35e0c7754a60c15c27e15a54a85a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to