BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/267469

Change subject: Revert "monolog: Ensure that context data added by WebProcessor 
is utf-8 safe"
......................................................................

Revert "monolog: Ensure that context data added by WebProcessor is utf-8 safe"

An upstream Monolog fix for this problem was
backported to mediawiki/vendor.git in I7a31a4d51291a5d9403478818805ffd1bb8fad86.

This reverts commit d66d3a458d74560bfea874b57da6aa540bbd7b3a.

Bug: T119594
Change-Id: I158b36971fbd511bec314efac1cac5bf44d4046b
---
M wmf-config/logging.php
1 file changed, 0 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/69/267469/1

diff --git a/wmf-config/logging.php b/wmf-config/logging.php
index 4c11863..4cf135a 100644
--- a/wmf-config/logging.php
+++ b/wmf-config/logging.php
@@ -49,22 +49,6 @@
        ),
        'web' => array(
                'class' => '\\Monolog\\Processor\\WebProcessor',
-               'args' => array(
-                       function () {
-                               // Ensure that context data added by 
WebProcessor is utf-8
-                               // safe by applying htmlentities() encoding
-                               $keys = array( 'REQUEST_URI', 'REMOTE_ADDR', 
'REQUEST_METHOD', 'SERVER_NAME', 'HTTP_REFERER' );
-                               $serverData = array();
-                               foreach ( $keys as $key ) {
-                                       if ( isset( $_SERVER[$key] ) ) {
-                                               $serverData[$key] = 
htmlentities(
-                                                       $_SERVER[$key], 
ENT_NOQUOTES, 'UTF-8', false
-                                               );
-                                       }
-                               }
-                               return $serverData;
-                       }
-               ),
        ),
 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/267469
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I158b36971fbd511bec314efac1cac5bf44d4046b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to