BBlack has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268596
Change subject: check_systemd_unit_state: allow active+exited for oneshot
......................................................................
check_systemd_unit_state: allow active+exited for oneshot
Change-Id: Ic8420a3c97551bd8361bede8a561620697bdf565
---
M modules/nrpe/files/plugins/check_systemd_unit_state
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/96/268596/1
diff --git a/modules/nrpe/files/plugins/check_systemd_unit_state
b/modules/nrpe/files/plugins/check_systemd_unit_state
index eec99cd..ca5e90e 100755
--- a/modules/nrpe/files/plugins/check_systemd_unit_state
+++ b/modules/nrpe/files/plugins/check_systemd_unit_state
@@ -86,7 +86,7 @@
if state['ActiveState'] != 'active':
crit("Expecting active but unit %s is %s" % (unit,
state['ActiveState']))
- if state['SubState'] != 'running':
+ if state['Type'] != 'oneshot' && state['SubState'] != 'running':
crit("Unit %s is active but reported %s'" % (unit,
state['SubState']))
ok("%s is active" % unit)
--
To view, visit https://gerrit.wikimedia.org/r/268596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8420a3c97551bd8361bede8a561620697bdf565
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <bbl...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
