jenkins-bot has submitted this change and it was merged. Change subject: Use the user who actually made the revision for onRevisionInsertComplete ......................................................................
Use the user who actually made the revision for onRevisionInsertComplete This is probably more correct, and avoids a log message from SessionManager. Bug: T124367 Change-Id: Idab3e093070cadfd5e18ceed30325d116e13b56f --- M WikimediaEventsHooks.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php index f5ac107..ae3be13 100644 --- a/WikimediaEventsHooks.php +++ b/WikimediaEventsHooks.php @@ -128,7 +128,7 @@ */ public static function onRevisionInsertComplete( &$revision, $data, $flags ) { $context = RequestContext::getMain(); - $user = $context->getUser(); + $user = User::newFromId( $revision->getUser( Revision::RAW ) ); // Anonymous users and bots don't count (sorry!) if ( $user->isAnon() || $user->isAllowed( 'bot' ) ) { -- To view, visit https://gerrit.wikimedia.org/r/268224 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idab3e093070cadfd5e18ceed30325d116e13b56f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaEvents Gerrit-Branch: master Gerrit-Owner: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits