Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268880
Change subject: Special:Newsletters: Make the filter form smaller
......................................................................
Special:Newsletters: Make the filter form smaller
* Remove fieldset/legend wrapper
* Decrease the width of the dropdown
Bug: T120519
Change-Id: I695fc3c394ca5586b60727f674f7f376a0689b3f
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialNewsletters.php
M modules/ext.newsletter.newsletters.styles.css
4 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/80/268880/1
diff --git a/i18n/en.json b/i18n/en.json
index f2b5bee..d2c8b77 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -122,7 +122,6 @@
"notification-header-newsletter-announce": "$1 {{GENDER:$2|has
announced}} a new issue of $3.",
"notification-body-newsletter-announce": "$1",
"newsletter-list-table": "Filter by: ",
- "newsletter-list-section": "Search for newsletters",
"newsletter-list-option-all": "All newsletters",
"newsletter-list-option-subscribed": "Newsletters I am subscribed to",
"newsletter-list-option-unsubscribed": "Newsletters I am not subscribed
to",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 2b738ad..9f6b146 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -126,7 +126,6 @@
"notification-header-newsletter-announce": "Header text for a
notification when a new issue of a newsletter is announced. Parameters:\n* $1
is that user's name (not suitable for GENDER).\n* $2 is the user's name for use
in GENDER.\n* $3 is the title of the newsletter.",
"notification-body-newsletter-announce": "Body text for a notification
when a new issue of a newsletter is announced. Parameters:\n* $1 is the summary
of the new newsletter issue.",
"newsletter-list-table": "Label of the drop down menu in
[[Special:Newsletters]], the options of which can be used to customize the
search of newsletters",
- "newsletter-list-section": "Section header of HTML form in
[[Special:Newsletters]] used to search for newsletters",
"newsletter-list-option-all": "Option of the drop down menu in
[[Special:Newsletters]] to display all newsletters",
"newsletter-list-option-subscribed": "Option of the drop down menu in
[[Special:Newsletters]] to display those newsletters to which the logged in
user is subscribed to",
"newsletter-list-option-unsubscribed": "Option of the drop down menu in
[[Special:Newsletters]] to display those newsletters to which the logged in
user is not subscribed to",
diff --git a/includes/specials/SpecialNewsletters.php
b/includes/specials/SpecialNewsletters.php
index 6f36ba4..963b80f 100644
--- a/includes/specials/SpecialNewsletters.php
+++ b/includes/specials/SpecialNewsletters.php
@@ -45,7 +45,6 @@
$filterTableForm->setMethod( 'get' );
$filterTableForm->setSubmitProgressive();
$filterTableForm->setSubmitTextMsg( 'newsletter-list-go-button'
);
- $filterTableForm->setWrapperLegendMsg(
'newsletter-list-section' );
$pager = new NewsletterTablePager();
$pager->setUserOption( $this->option );
diff --git a/modules/ext.newsletter.newsletters.styles.css
b/modules/ext.newsletter.newsletters.styles.css
index d7edf94..0e697b2 100644
--- a/modules/ext.newsletter.newsletters.styles.css
+++ b/modules/ext.newsletter.newsletters.styles.css
@@ -11,6 +11,13 @@
display: none;
}
+/**
+ * The default dropdown is rather wide so we'll make it a bit small to make it
look nicer.
+ */
+#mw-newsletter-filter-options {
+ width: 40%;
+}
+
/* Styling for "Subscribe/Unsubscribe" links */
.newsletter-subscribed,
.newsletter-subscribed:link, .newsletter-subscribed:visited {
--
To view, visit https://gerrit.wikimedia.org/r/268880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I695fc3c394ca5586b60727f674f7f376a0689b3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
