jenkins-bot has submitted this change and it was merged.
Change subject: BugID 43076 - Fixes to alien and phantom corner cases
......................................................................
BugID 43076 - Fixes to alien and phantom corner cases
The {{coords}} template is correctly rendered as an inlineAlien, which
previously did not have shields. However, the template has a deeply nested span
that is positioned and floated. The fix is to shift shielding logic up to
AlienNode (from AlienBlockNode) and to show phantoms on all shields (both block
and inline). I've also updated the aliens demo to exhibit this corner case.
Change-Id: Ifce60c7762c0ead5c6fe29d6eabf601c1565cbfa
---
M demos/ve/pages/aliens.html
M modules/ve/ce/nodes/ve.ce.AlienBlockNode.js
M modules/ve/ce/nodes/ve.ce.AlienInlineNode.js
M modules/ve/ce/nodes/ve.ce.AlienNode.js
4 files changed, 43 insertions(+), 63 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
--
To view, visit https://gerrit.wikimedia.org/r/39834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifce60c7762c0ead5c6fe29d6eabf601c1565cbfa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Christian <christ...@wikia-inc.com>
Gerrit-Reviewer: Inez <i...@wikia-inc.com>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
