Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/269400
Change subject: Remove unnecessary and expensive value() calls
......................................................................
Remove unnecessary and expensive value() calls
Change-Id: Iaf9bb713e4f9d148a85897fb07cea1952adde962
---
M
view/resources/jquery/wikibase/toolbar/controller/definitions/addtoolbar/statementlistview-statementview.js
M
view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/statementview.js
2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/00/269400/1
diff --git
a/view/resources/jquery/wikibase/toolbar/controller/definitions/addtoolbar/statementlistview-statementview.js
b/view/resources/jquery/wikibase/toolbar/controller/definitions/addtoolbar/statementlistview-statementview.js
index b84d267..30b9b70 100644
---
a/view/resources/jquery/wikibase/toolbar/controller/definitions/addtoolbar/statementlistview-statementview.js
+++
b/view/resources/jquery/wikibase/toolbar/controller/definitions/addtoolbar/statementlistview-statementview.js
@@ -18,7 +18,7 @@
$container = $statementlistview.children(
'.wikibase-toolbar-wrapper' )
.children(
'.wikibase-toolbar-container' );
- if ( !statementlistview.value().length ) {
+ if ( statementlistview.isEmpty() ) {
return;
}
@@ -27,10 +27,6 @@
$container = $( '<div/>' ).appendTo(
mw.wbTemplate(
'wikibase-toolbar-wrapper', '' ).appendTo( $statementlistview )
);
- }
-
- if ( !statementlistview.value() ) {
- return;
}
$statementlistview.addtoolbar( {
diff --git
a/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/statementview.js
b/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/statementview.js
index 5eeb335..d5a5ddc 100644
---
a/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/statementview.js
+++
b/view/resources/jquery/wikibase/toolbar/controller/definitions/edittoolbar/statementview.js
@@ -26,7 +26,7 @@
options.$container = $container;
- if ( !!statementview.value() ) {
+ if ( statementview.option( 'value' ) ) {
options.onRemove = function() {
var $statementlistview
=
$statementview.closest( ':wikibase-statementlistview' ),
--
To view, visit https://gerrit.wikimedia.org/r/269400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf9bb713e4f9d148a85897fb07cea1952adde962
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.he...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
