Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/269623
Change subject: Make some public member variables private
......................................................................
Make some public member variables private
Change-Id: I46e8aff1496cdbc929c7fa9e5502a44a4c3b9fbc
---
M lib/includes/LanguageFallbackChainFactory.php
M lib/tests/phpunit/formatters/AutoCommentFormatterTest.php
M lib/tests/phpunit/store/CachingPropertyInfoStoreTest.php
M lib/tests/phpunit/store/MockPropertyInfoStoreTest.php
M lib/tests/phpunit/store/Sql/PropertyInfoTableTest.php
M repo/tests/phpunit/includes/ChangePrunerTest.php
6 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/23/269623/1
diff --git a/lib/includes/LanguageFallbackChainFactory.php
b/lib/includes/LanguageFallbackChainFactory.php
index 5f1bae2..b97c090 100644
--- a/lib/includes/LanguageFallbackChainFactory.php
+++ b/lib/includes/LanguageFallbackChainFactory.php
@@ -42,17 +42,17 @@
/**
* @var array[]
*/
- public $languageCache;
+ private $languageCache;
/**
* @var array[]
*/
- public $userLanguageCache;
+ private $userLanguageCache;
/**
* @var bool
*/
- public $anonymousPageViewCached;
+ private $anonymousPageViewCached;
/**
* @param bool $anonymousPageViewCached Whether full page outputs are
cached for anons, so some
diff --git a/lib/tests/phpunit/formatters/AutoCommentFormatterTest.php
b/lib/tests/phpunit/formatters/AutoCommentFormatterTest.php
index eb4dc25..779976f 100644
--- a/lib/tests/phpunit/formatters/AutoCommentFormatterTest.php
+++ b/lib/tests/phpunit/formatters/AutoCommentFormatterTest.php
@@ -20,7 +20,7 @@
/**
* @var Language
*/
- public $language;
+ private $language;
/**
* @var string LEFT-TO-RIGHT MARK, commonly abbreviated LRM from
Language.php
diff --git a/lib/tests/phpunit/store/CachingPropertyInfoStoreTest.php
b/lib/tests/phpunit/store/CachingPropertyInfoStoreTest.php
index 414cca3..5264963 100644
--- a/lib/tests/phpunit/store/CachingPropertyInfoStoreTest.php
+++ b/lib/tests/phpunit/store/CachingPropertyInfoStoreTest.php
@@ -23,7 +23,7 @@
/**
* @var PropertyInfoStoreTestHelper
*/
- public $helper;
+ private $helper;
public function __construct( $name = null, $data = array(), $dataName =
'' ) {
parent::__construct( $name, $data, $dataName );
diff --git a/lib/tests/phpunit/store/MockPropertyInfoStoreTest.php
b/lib/tests/phpunit/store/MockPropertyInfoStoreTest.php
index 1a4d1b7..da2db84 100644
--- a/lib/tests/phpunit/store/MockPropertyInfoStoreTest.php
+++ b/lib/tests/phpunit/store/MockPropertyInfoStoreTest.php
@@ -22,7 +22,7 @@
/**
* @var PropertyInfoStoreTestHelper
*/
- public $helper;
+ private $helper;
public function __construct( $name = null, $data = array(), $dataName =
'' ) {
parent::__construct( $name, $data, $dataName );
diff --git a/lib/tests/phpunit/store/Sql/PropertyInfoTableTest.php
b/lib/tests/phpunit/store/Sql/PropertyInfoTableTest.php
index 223dd8f..7585a23 100644
--- a/lib/tests/phpunit/store/Sql/PropertyInfoTableTest.php
+++ b/lib/tests/phpunit/store/Sql/PropertyInfoTableTest.php
@@ -23,7 +23,7 @@
/**
* @var PropertyInfoStoreTestHelper
*/
- public $helper;
+ private $helper;
public function __construct( $name = null, $data = array(), $dataName =
'' ) {
parent::__construct( $name, $data, $dataName );
diff --git a/repo/tests/phpunit/includes/ChangePrunerTest.php
b/repo/tests/phpunit/includes/ChangePrunerTest.php
index 455a2f2..1b81652 100644
--- a/repo/tests/phpunit/includes/ChangePrunerTest.php
+++ b/repo/tests/phpunit/includes/ChangePrunerTest.php
@@ -21,7 +21,7 @@
*/
class ChangePrunerTest extends MediaWikiTestCase {
- public $messages = array();
+ private $messages = array();
public function testConstructorWithInvalidBatchSize() {
$this->setExpectedException( 'InvalidArgumentException' );
--
To view, visit https://gerrit.wikimedia.org/r/269623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46e8aff1496cdbc929c7fa9e5502a44a4c3b9fbc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
