jenkins-bot has submitted this change and it was merged.
Change subject: Strict comparison for booleans
......................................................................
Strict comparison for booleans
Change-Id: Id4d16093ed860942e2dfa561e124482ade0d6381
---
M includes/WikidataPageBanner.functions.php
M includes/WikidataPageBanner.hooks.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/WikidataPageBanner.functions.php
b/includes/WikidataPageBanner.functions.php
index d5058aa..19a626a 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -295,7 +295,7 @@
$entityLookup =
Wikibase\Client\WikibaseClient::getDefaultInstance()
->getStore()
->getEntityLookup();
- if ( $itemId != null ) {
+ if ( $itemId !== null ) {
$item = $entityLookup->getEntity( $itemId );
$statements =
$item->getStatements()->getByPropertyId(
new
Wikibase\DataModel\Entity\PropertyId(
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 2866dce..31cdc94 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -149,7 +149,7 @@
* @param ParserOutput $pOut
*/
public static function onOutputPageParserOutput( OutputPage $out,
ParserOutput $pOut ) {
- if ( $pOut->getExtensionData( 'wpb-banner-options' ) != null ) {
+ if ( $pOut->getExtensionData( 'wpb-banner-options' ) !== null )
{
$options = $pOut->getExtensionData(
'wpb-banner-options' );
// if toc parameter set and toc enabled, remove
original classes and add banner class
--
To view, visit https://gerrit.wikimedia.org/r/268485
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4d16093ed860942e2dfa561e124482ade0d6381
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Dereckson <dereck...@espace-win.org>
Gerrit-Reviewer: Dereckson <dereck...@espace-win.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
