Xqt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/269730
Change subject: [bugfix] top['total'] item is basestring not unicode
......................................................................
[bugfix] top['total'] item is basestring not unicode
* also fix entry index for fr-wikisource
Change-Id: Iff6266e4bcbebe2f859bcba4feb326fa8be26091
---
M tests/wikistats_tests.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/30/269730/1
diff --git a/tests/wikistats_tests.py b/tests/wikistats_tests.py
index 4d59623..d3f00fe 100644
--- a/tests/wikistats_tests.py
+++ b/tests/wikistats_tests.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
"""Test cases for the WikiStats dataset."""
#
-# (C) Pywikibot team, 2014
+# (C) Pywikibot team, 2014-2016
#
# Distributed under the terms of the MIT license.
#
@@ -11,7 +11,7 @@
#
from pywikibot.data.wikistats import WikiStats, csv
-from pywikibot.tools import UnicodeType
+from pywikibot.tools import StringTypes
from tests.aspects import unittest, TestCase
@@ -30,9 +30,9 @@
self.assertIn('prefix', top)
self.assertIn('total', top)
self.assertEqual(top['prefix'], 'en')
- self.assertIsInstance(top['total'], UnicodeType)
+ self.assertIsInstance(top['total'], StringTypes)
self.assertEqual(ws.languages_by_size('wikipedia')[0], 'en')
- self.assertEqual(ws.languages_by_size('wikisource')[0], 'fr')
+ self.assertEqual(ws.languages_by_size('wikisource')[3], 'fr')
def test_csv(self):
"""Test CSV."""
--
To view, visit https://gerrit.wikimedia.org/r/269730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff6266e4bcbebe2f859bcba4feb326fa8be26091
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
