Bmansurov has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/269971

Change subject: Fix the failing browser test
......................................................................

Fix the failing browser test

Also:
* Update the documentation
* Use the desktop site by deafult as we have a step that allows us
switching to mobile if needed but not the vice versa

Bug: T120715
Change-Id: I025740546655512bf24490433200f4865a6d7331
---
M tests/browser/README.mediawiki
M tests/browser/environments.yml
M tests/browser/features/support/pages/special_preferences_page.rb
3 files changed, 7 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/71/269971/1

diff --git a/tests/browser/README.mediawiki b/tests/browser/README.mediawiki
index c797780..4ca73f3 100644
--- a/tests/browser/README.mediawiki
+++ b/tests/browser/README.mediawiki
@@ -45,7 +45,11 @@
 call 'bundle exec cucumber' with the path to the test file. For example, to run
 only the watchlist tests:
 
-  bundle exec cucumber features/read_more_desktop.feature
+  bundle exec cucumber features/read_more.feature
+
+You can also run tests starting a certain line like so:
+
+  bundle exec cucumber features/read_more.feature:28
 
 XML report (for Jenkins) is created at tests/browser/reports/junit.
 
diff --git a/tests/browser/environments.yml b/tests/browser/environments.yml
index cb14ed5..062a4cf 100644
--- a/tests/browser/environments.yml
+++ b/tests/browser/environments.yml
@@ -28,7 +28,7 @@
   user_factory: true
 
 beta:
-  mediawiki_url: http://en.m.wikipedia.beta.wmflabs.org/wiki/
+  mediawiki_url: http://en.wikipedia.beta.wmflabs.org/wiki/
   mediawiki_user: Selenium_user
   # mediawiki_password: SET THIS IN THE ENVIRONMENT!
 
diff --git a/tests/browser/features/support/pages/special_preferences_page.rb 
b/tests/browser/features/support/pages/special_preferences_page.rb
index d9e1d6f..19ab6d2 100644
--- a/tests/browser/features/support/pages/special_preferences_page.rb
+++ b/tests/browser/features/support/pages/special_preferences_page.rb
@@ -9,7 +9,7 @@
   def enable_read_more
     beta_features_tab_element.when_present.click
     if read_more_checkbox_element.attribute('checked').nil?
-      read_more_checkbox_element.when_present.click
+      read_more_checkbox_element.click
     end
     submit_button_element.when_present.click
   end

-- 
To view, visit https://gerrit.wikimedia.org/r/269971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I025740546655512bf24490433200f4865a6d7331
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to