Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/270865
Change subject: Element#scrollIntoView: Make the promise version actually work ...................................................................... Element#scrollIntoView: Make the promise version actually work Previously, the promise would never be resolved if no scrolling was needed. Follow-up to 1dc6a455289b2b8c5ec6a641d21103e2697493b1. Change-Id: I14ccec834fe5d146f768e745ec2fe4ef22231e40 --- M src/Element.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/65/270865/1 diff --git a/src/Element.js b/src/Element.js index b2f5ebd..11e5d72 100644 --- a/src/Element.js +++ b/src/Element.js @@ -659,8 +659,8 @@ } else { if ( callback ) { callback(); - deferred.resolve(); } + deferred.resolve(); } return deferred.promise(); }; -- To view, visit https://gerrit.wikimedia.org/r/270865 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14ccec834fe5d146f768e745ec2fe4ef22231e40 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits