JanZerebecki has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/271021

Change subject: Make sure to ignore vendor and node_modules
......................................................................

Make sure to ignore vendor and node_modules

Otherwise js tools may pick them up even though they are not part of this
repository/component.

Also make sure top level path are anchored in .gitignore .

Change-Id: I5d4f88f0a56a9d49874a60723162b0f714fed794
---
M .gitignore
M .jscsrc
M .jshintignore
M Gruntfile.js
4 files changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BoilerPlate 
refs/changes/21/271021/1

diff --git a/.gitignore b/.gitignore
index 5820100..59a2a36 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,6 @@
 .*.swp
 *~
-.project
-composer.lock
-vendor
-node_modules
+/.project
+/composer.lock
+/vendor
+/node_modules
diff --git a/.jscsrc b/.jscsrc
index 9d22e3f..04baa68 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -1,3 +1,4 @@
 {
-       "preset": "wikimedia"
+       "preset": "wikimedia",
+       "excludeFiles": [ "node_modules/**", "vendor/**" ]
 }
diff --git a/.jshintignore b/.jshintignore
index 3c3629e..82eaa05 100644
--- a/.jshintignore
+++ b/.jshintignore
@@ -1 +1,2 @@
-node_modules
+node_modules/**
+vendor/**
diff --git a/Gruntfile.js b/Gruntfile.js
index 69e6d05..36b41e8 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -24,7 +24,8 @@
                jsonlint: {
                        all: [
                                '**/*.json',
-                               '!node_modules/**'
+                               '!node_modules/**',
+                               '!vendor/**'
                        ]
                }
        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/271021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d4f88f0a56a9d49874a60723162b0f714fed794
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BoilerPlate
Gerrit-Branch: master
Gerrit-Owner: JanZerebecki <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to