Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/271262

Change subject: Logging in via LoginPage#login_with is a security risk
......................................................................

Logging in via LoginPage#login_with is a security risk

Log in via the API instead.

Bug: T127042
Change-Id: I3ee91b5f674daacca0bf80bd95a7d871715b2ef3
---
M tests/browser/features/step_definitions/translation_stash_steps.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/62/271262/1

diff --git a/tests/browser/features/step_definitions/translation_stash_steps.rb 
b/tests/browser/features/step_definitions/translation_stash_steps.rb
index 9aa4ed5..a5646ff 100644
--- a/tests/browser/features/step_definitions/translation_stash_steps.rb
+++ b/tests/browser/features/step_definitions/translation_stash_steps.rb
@@ -1,5 +1,5 @@
 Given(/^I am logged in at sandbox$/) do
-  visit(LoginPage).login_with(user, password, false)
+  log_in
 end
 
 Given(/^I am a sandboxed user on the stash page$/) do

-- 
To view, visit https://gerrit.wikimedia.org/r/271262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ee91b5f674daacca0bf80bd95a7d871715b2ef3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to