[MediaWiki-commits] [Gerrit] Don't remove .ve-activated after successfully activating - change (mediawiki...VisualEditor)

[Alex Monk (Code Review)]

Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/271278

Change subject: Don't remove .ve-activated after successfully activating
......................................................................

Don't remove .ve-activated after successfully activating

hideLoading always gets called after activating, not just failing

Follows-up: I13058ae1

Bug: T127184
Change-Id: I47d1892feacbfcf832aa32f689f173601b76c4ba
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/78/271278/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index b417a64..6d2c1ef 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -80,7 +80,7 @@
        }
 
        function hideLoading() {
-               $( 'html' ).removeClass( 've-activated ve-loading' );
+               $( 'html' ).removeClass( 've-loading' );
                if ( init.$loading ) {
                        init.$loading.detach();
                }
@@ -89,6 +89,7 @@
        function handleLoadFailure() {
                resetLoadingProgress();
                if ( $( '#wpTextbox1' ).length || mw.config.get( 'wgAction' ) 
!== 'edit' ) {
+                       $( 'html' ).removeClass( 've-activated' );
                        hideLoading();
                } else {
                        location.href = viewUri.clone().extend( { action: 
'edit', veswitched: 1 } );

-- 
To view, visit https://gerrit.wikimedia.org/r/271278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47d1892feacbfcf832aa32f689f173601b76c4ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits