Eileen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/271447

Change subject: Get more info when contribution create fails
......................................................................

Get more info when contribution create fails

I just saw this in the failmail

Error: INVALID_MESSAGE Cannot create contribution, civi error!
Source: 'DB Error: unknown error'

There is not enough info to tell what it relates to so this patch increased the 
error info

Change-Id: I93ad1ced10a397e99fb87b8a5ce93e8ad5659e07
---
M sites/all/modules/wmf_civicrm/wmf_civicrm.module
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/47/271447/1

diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module 
b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
index 0e7ecaa..f1cb21b 100644
--- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
@@ -326,6 +326,7 @@
         'contribution_recur_id' => $msg['contribution_recur_id'],
         'check_number' => $msg['check_number'],
         'soft_credit_to' => $msg['soft_credit_to_id'],
+        'debug' => TRUE,
 
         // API required fields
         'version' => '3'
@@ -406,16 +407,15 @@
     }
 
     watchdog( 'wmf_civicrm', 'Contribution array for 
civicrm_contribution_add(): ' . print_r($contribution, TRUE), NULL, 
WATCHDOG_DEBUG);
-
-    $contribution_result = civicrm_api( "Contribution", "Create", 
$contribution );
-
-    watchdog( 'wmf_civicrm', 'Contribution result from 
civicrm_contribution_add(): ' . print_r($contribution_result, TRUE), NULL, 
WATCHDOG_DEBUG);
-
-    if ( array_key_exists( 'is_error', $contribution_result ) && 
$contribution_result['is_error'] != 0 ) {
+    try {
+      $contribution_result = civicrm_api3("Contribution", "Create", 
$contribution);
+      watchdog('wmf_civicrm', 'Contribution result from 
civicrm_contribution_add(): ' . print_r($contribution_result, TRUE), NULL, 
WATCHDOG_DEBUG);
+    }
+    catch (CiviCRM_API3_Exception $e) {
         throw new WmfException(
             'INVALID_MESSAGE',
             'Cannot create contribution, civi error!',
-            $contribution_result['error_message']
+            $e->getMessage() . print_r($e->getExtraParams(), TRUE),
         );
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/271447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I93ad1ced10a397e99fb87b8a5ce93e8ad5659e07
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen <emcnaugh...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to