Wctaiwan has uploaded a new change for review. https://gerrit.wikimedia.org/r/271448
Change subject: Fix link element ...................................................................... Fix link element Add an href attribute so that it's a proper link with the correct cursor type. Change-Id: I32dd9c21390c6a7fef997bef1f2724120c3f1bff --- M resources/ext.wmpageviewinfo.js 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaPageViewInfo refs/changes/48/271448/1 diff --git a/resources/ext.wmpageviewinfo.js b/resources/ext.wmpageviewinfo.js index e3600f4..a901271 100644 --- a/resources/ext.wmpageviewinfo.js +++ b/resources/ext.wmpageviewinfo.js @@ -4,10 +4,12 @@ count = $count.text(); // Turn it into an <a> tag so it's obvious you can click on it - $count.html( mw.html.element( 'a', {}, count ) ); + $count.html( mw.html.element( 'a', { href: '#' }, count ) ); - $count.click( function () { + $count.click( function ( e ) { var myDialog, windowManager; + e.preventDefault(); + // A simple dialog window. function MyDialog( config ) { MyDialog.parent.call( this, config ); -- To view, visit https://gerrit.wikimedia.org/r/271448 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32dd9c21390c6a7fef997bef1f2724120c3f1bff Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaPageViewInfo Gerrit-Branch: master Gerrit-Owner: Wctaiwan <wctai...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits