Haritha28 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271468
Change subject: Gadgets tab on Special: Preferences badly formatted
......................................................................
Gadgets tab on Special: Preferences badly formatted
The section headers are changed from <h1> to <h2>
and the "label =  " is removed.
Bug: T46231
Change-Id: Ica05064ba2f4a43c15898b4111099d73cf5fe4ea
---
M includes/htmlform/HTMLMultiSelectField.php
M tests/phpunit/includes/api/ApiOptionsTest.php
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/68/271468/1
diff --git a/includes/htmlform/HTMLMultiSelectField.php
b/includes/htmlform/HTMLMultiSelectField.php
index 251bb05..04dbc56 100644
--- a/includes/htmlform/HTMLMultiSelectField.php
+++ b/includes/htmlform/HTMLMultiSelectField.php
@@ -41,7 +41,7 @@
foreach ( $options as $label => $info ) {
if ( is_array( $info ) ) {
- $html .= Html::rawElement( 'h1', [], $label ) .
"\n";
+ $html .= Html::rawElement( 'h2', [], $label ) .
"\n";
$html .= $this->formatOptions( $info, $value );
} else {
$thisAttribs = [
diff --git a/tests/phpunit/includes/api/ApiOptionsTest.php
b/tests/phpunit/includes/api/ApiOptionsTest.php
index 0a577c1..3bb1b0d 100644
--- a/tests/phpunit/includes/api/ApiOptionsTest.php
+++ b/tests/phpunit/includes/api/ApiOptionsTest.php
@@ -66,7 +66,6 @@
$preferences[$k] = [
'type' => 'text',
'section' => 'test',
- 'label' => ' ',
];
}
--
To view, visit https://gerrit.wikimedia.org/r/271468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica05064ba2f4a43c15898b4111099d73cf5fe4ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Haritha28 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
