Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271533
Change subject: Fix Cucumber tags for Selenium tests
......................................................................
Fix Cucumber tags for Selenium tests
no_javascript.feature was not running for Chrome, but it works fine.
Fixed.
We are no longer running any Echo tests in Internet Explorer. Fixed.
The second scenario in notifications.feature fails at
en.wikipedia.beta.wmflabs.org with `Direct editing via API is not
supported for content model flow-board used by User_talk:Selenium_user
(no-direct-editing) (MediawikiApi::ApiError)`, so that scenario no
longer runs there.
All scenarios run just fine when targeting mediawiki-vagrant machine
with echo role, so I have added @vagrant tag to both feature files.
Bug: T94152
Change-Id: I2c206048c615583bacc9d6c5f5c2e6ffeaea3462
---
M tests/browser/features/no_javascript.feature
M tests/browser/features/notifications.feature
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/33/271533/1
diff --git a/tests/browser/features/no_javascript.feature
b/tests/browser/features/no_javascript.feature
index bd9c6fd..f46fbc3 100644
--- a/tests/browser/features/no_javascript.feature
+++ b/tests/browser/features/no_javascript.feature
@@ -1,5 +1,4 @@
-@firefox
-@en.wikipedia.beta.wmflabs.org @integration
+@chrome @en.wikipedia.beta.wmflabs.org @firefox @integration @vagrant
Feature: Basic features for no-js functionality
Background:
diff --git a/tests/browser/features/notifications.feature
b/tests/browser/features/notifications.feature
index f761914..aeb5da0 100644
--- a/tests/browser/features/notifications.feature
+++ b/tests/browser/features/notifications.feature
@@ -1,11 +1,11 @@
-@chrome @firefox @internet_explorer_10
-@en.wikipedia.beta.wmflabs.org @integration
+@chrome @firefox @integration @vagrant
Feature: Testing notification types
Background:
Given I am logged in
And all my notifications are read
+ @en.wikipedia.beta.wmflabs.org
Scenario: Someone mentions me
Given another user mentions me
When I refresh the page
--
To view, visit https://gerrit.wikimedia.org/r/271533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c206048c615583bacc9d6c5f5c2e6ffeaea3462
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
