Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/271777
Change subject: Cleanup Cucumber tags in Selenium tests ...................................................................... Cleanup Cucumber tags in Selenium tests Removing no longer used @login tag. Bug: T127423 Change-Id: I25672e377f163920991986c01c52c4522cc84458 --- M tests/browser/features/signed_in_and_approved_users.feature M tests/browser/features/signed_in_source_language.feature M tests/browser/features/user_signed_in_not_approved.feature M tests/browser/tags.txt 4 files changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage refs/changes/77/271777/1 diff --git a/tests/browser/features/signed_in_and_approved_users.feature b/tests/browser/features/signed_in_and_approved_users.feature index 6c424c0..e7d0d91 100644 --- a/tests/browser/features/signed_in_and_approved_users.feature +++ b/tests/browser/features/signed_in_and_approved_users.feature @@ -1,4 +1,4 @@ -@firefox @login +@firefox Feature: View for approved users Sign-in and first display -> one scenario to verify if the user sees the diff --git a/tests/browser/features/signed_in_source_language.feature b/tests/browser/features/signed_in_source_language.feature index ea39617..8ba6f37 100644 --- a/tests/browser/features/signed_in_source_language.feature +++ b/tests/browser/features/signed_in_source_language.feature @@ -1,4 +1,4 @@ -@firefox @login @sandbox.translatewiki.net +@firefox @sandbox.translatewiki.net Feature: Main page in the source language Source language in this case means that the source language of all message diff --git a/tests/browser/features/user_signed_in_not_approved.feature b/tests/browser/features/user_signed_in_not_approved.feature index 85841be..c7520d9 100644 --- a/tests/browser/features/user_signed_in_not_approved.feature +++ b/tests/browser/features/user_signed_in_not_approved.feature @@ -1,4 +1,4 @@ -@firefox @login +@firefox Feature: Signed-in New Users who have not been approved (only onboarding view will be available for them) Background: diff --git a/tests/browser/tags.txt b/tests/browser/tags.txt index df7d065..ee0337c 100644 --- a/tests/browser/tags.txt +++ b/tests/browser/tags.txt @@ -1,9 +1,5 @@ This file contains the descriptions of the tags we use. -@login - This test logs in. You can filter these tests out if you don't have an - account available. - @reset-preferences-after This test changes user preferences and resets them at the end. In theory you could use your normal user account if you skip these tests, but I would not -- To view, visit https://gerrit.wikimedia.org/r/271777 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25672e377f163920991986c01c52c4522cc84458 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TwnMainPage Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
