Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/271781
Change subject: Cleanup Cucumber tags in Selenium tests ...................................................................... Cleanup Cucumber tags in Selenium tests Removing no longer used @login tag. We are no longer running tests using internet explorer or phantomjs, so removing those tags too. Renamed @clean tag with @vagrant, since it makes more sense and is used in other repositories. Bug: T127423 Change-Id: Ib5e0a1600c3df45889e97d5ff52cd0a77a15001f --- M tests/browser/features/create_account.feature M tests/browser/features/create_and_follow_wiki_link.feature M tests/browser/features/edit_page.feature M tests/browser/features/file.feature M tests/browser/features/login.feature M tests/browser/features/main_page_links.feature M tests/browser/features/preferences.feature M tests/browser/features/view_history.feature 8 files changed, 8 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/81/271781/1 diff --git a/tests/browser/features/create_account.feature b/tests/browser/features/create_account.feature index 35df8b4..8029182 100644 --- a/tests/browser/features/create_account.feature +++ b/tests/browser/features/create_account.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @phantomjs +@chrome @firefox @vagrant Feature: Create account Scenario Outline: Go to Create account page diff --git a/tests/browser/features/create_and_follow_wiki_link.feature b/tests/browser/features/create_and_follow_wiki_link.feature index a0aa624..510c467 100644 --- a/tests/browser/features/create_and_follow_wiki_link.feature +++ b/tests/browser/features/create_and_follow_wiki_link.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @login @phantomjs +@chrome @firefox @vagrant Feature: Create Page With Wiki Link Scenario: Create Page With Wiki Link diff --git a/tests/browser/features/edit_page.feature b/tests/browser/features/edit_page.feature index b905795..ade6914 100644 --- a/tests/browser/features/edit_page.feature +++ b/tests/browser/features/edit_page.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @login @phantomjs +@chrome @firefox @vagrant Feature: Edit Page Scenario: Create and edit page diff --git a/tests/browser/features/file.feature b/tests/browser/features/file.feature index 35a6675..0b59c88 100644 --- a/tests/browser/features/file.feature +++ b/tests/browser/features/file.feature @@ -1,11 +1,10 @@ -@chrome @clean @firefox @internet_explorer_6 @internet_explorer_7 @internet_explorer_8 @internet_explorer_9 @internet_explorer_10 @phantomjs +@chrome @firefox @vagrant Feature: File Scenario: Anonymous goes to file that does not exist Given I am at file that does not exist Then page should show that no such file exists - @login Scenario: Logged-in user goes to file that does not exist Given I am logged in And I am at file that does not exist diff --git a/tests/browser/features/login.feature b/tests/browser/features/login.feature index 7ed66a0..c18f087 100644 --- a/tests/browser/features/login.feature +++ b/tests/browser/features/login.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @internet_explorer_6 @internet_explorer_7 @internet_explorer_8 @internet_explorer_9 @internet_explorer_10 @phantomjs +@chrome @firefox @vagrant Feature: Log in Background: @@ -25,7 +25,6 @@ When I log in with incorrect password Then error box should be visible - @login Scenario: Log in with valid credentials When I log in Then error box should not be visible diff --git a/tests/browser/features/main_page_links.feature b/tests/browser/features/main_page_links.feature index 3613c82..1f3621b 100644 --- a/tests/browser/features/main_page_links.feature +++ b/tests/browser/features/main_page_links.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @phantomjs +@chrome @firefox @vagrant Feature: Main Page View History Links Background: diff --git a/tests/browser/features/preferences.feature b/tests/browser/features/preferences.feature index 9fed9cf..9c6c553 100644 --- a/tests/browser/features/preferences.feature +++ b/tests/browser/features/preferences.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @internet_explorer_6 @internet_explorer_7 @internet_explorer_8 @internet_explorer_9 @internet_explorer_10 @login @phantomjs +@chrome @firefox @vagrant Feature: Preferences Scenario: Preferences Appearance @@ -18,7 +18,6 @@ And I can see local time And I can select my time zone - Scenario: Preferences Editing Given I am logged in When I navigate to Preferences @@ -33,7 +32,6 @@ And I can select show preview on first edit And I can select show preview before edit box And I can select live preview - Scenario: Preferences User profile Given I am logged in diff --git a/tests/browser/features/view_history.feature b/tests/browser/features/view_history.feature index ba61ebd..95136d2 100644 --- a/tests/browser/features/view_history.feature +++ b/tests/browser/features/view_history.feature @@ -1,4 +1,4 @@ -@chrome @clean @firefox @phantomjs +@chrome @firefox @vagrant Feature: View History Scenario: Edit page and view history -- To view, visit https://gerrit.wikimedia.org/r/271781 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5e0a1600c3df45889e97d5ff52cd0a77a15001f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits