Tim Landscheidt has submitted this change and it was merged.
Change subject: Let take fail if recursion failed
......................................................................
Let take fail if recursion failed
Currently, calling take on a directory succeeds if the directory
itself could be assumed ownership of regardless of its children.
While the logic to sum up the results of the recursion was in the
source code, its result was ignored.
This change implements the common behaviour for a program to only
succeed if there were no errors at all.
Change-Id: I3415bf8ee0643a1f16191426b804684680878a20
---
M src/take.cc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tim Landscheidt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/take.cc b/src/take.cc
index 41a16ad..ffb6d57 100755
--- a/src/take.cc
+++ b/src/take.cc
@@ -157,6 +157,8 @@
ok &= takeover(d->d_name, true);
}
closedir(df);
+
+ return ok;
} else
return error(path);
}
--
To view, visit https://gerrit.wikimedia.org/r/268931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3415bf8ee0643a1f16191426b804684680878a20
Gerrit-PatchSet: 3
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: Tim Landscheidt <t...@tim-landscheidt.de>
Gerrit-Reviewer: Yuvipanda <yuvipa...@wikimedia.org>
Gerrit-Reviewer: coren <mpellet...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
