jenkins-bot has submitted this change and it was merged. Change subject: Prevent leak of GalleryItemFragment. ......................................................................
Prevent leak of GalleryItemFragment. Once again, the leak is prevented by clearing out several listeners that hold references to the fragment. Change-Id: I6127b983a87c379ebd66d210103bbd83a6134b95 --- M app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Niedzielski: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java b/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java index 6e865b8..a5bbe3b 100644 --- a/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java +++ b/app/src/main/java/org/wikipedia/page/gallery/GalleryItemFragment.java @@ -130,6 +130,15 @@ } } + @Override + public void onDestroyView() { + super.onDestroyView(); + imageView.setController(null); + imageView.setOnClickListener(null); + videoThumbnail.setController(null); + videoThumbnail.setOnClickListener(null); + } + private void updateProgressBar(boolean visible, boolean indeterminate, int value) { progressBar.setIndeterminate(indeterminate); if (!indeterminate) { -- To view, visit https://gerrit.wikimedia.org/r/272742 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6127b983a87c379ebd66d210103bbd83a6134b95 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits