jenkins-bot has submitted this change and it was merged.
Change subject: More general .teahouse-ask button styling
......................................................................
More general .teahouse-ask button styling
This removes the restriction that the class can only be used in a
<span>. I'm also changing the style a bit to be closer to .mw-ui-...
styles, most notably the padding. The added "a" and "a.external"
selectors are useful because each button should have a no-JS
alternative.
Change-Id: I8e2a03c9abeafcaa9e6c1c95a3a3a10d44dcfaf5
---
M resources/mediawiki.util.teahouse.css
1 file changed, 15 insertions(+), 12 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
Daniel Kinzler: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/mediawiki.util.teahouse.css
b/resources/mediawiki.util.teahouse.css
index 136df97..4ee4d48 100644
--- a/resources/mediawiki.util.teahouse.css
+++ b/resources/mediawiki.util.teahouse.css
@@ -1,4 +1,4 @@
-#p-teahouse > a{
+#p-teahouse > a {
font-weight: bold;
color: #F0F0F0;
background-color: #27AA65; /*
https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Color_usage */
@@ -54,7 +54,6 @@
padding: 0.25em 0.45em 0.2em 0.45em;
margin-left: -4px;
text-align: center;
- /*background-color: #d2d2d2;*/
font-weight: bold;
color: white;
cursor: pointer;
@@ -63,10 +62,6 @@
a.teahouse-unread-notifications {
background-color: #27AA65;
-}
-
-.teahouse-error-details {
- /* display: none; */
}
.teahouse-error-details table {
@@ -79,10 +74,18 @@
padding: 0.5em;
}
-span.teahouse-ask {
- display: inline-block;
+/* Partly borrowed from .mw-ui-button */
+.teahouse-ask {
background-color: #27AA65;
- padding: 0.5em;
- color:#F0F0F0;
- cursor:pointer
-}
\ No newline at end of file
+ color: #F0F0F0;
+ cursor: pointer;
+ display: inline-block;
+ font-weight: bold;
+ padding: 0.5em 1em;
+}
+
+.teahouse-ask a,
+.teahouse-ask a.external {
+ color: #F0F0F0;
+ text-decoration: none;
+}
--
To view, visit https://gerrit.wikimedia.org/r/230060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e2a03c9abeafcaa9e6c1c95a3a3a10d44dcfaf5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Teahouse
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Aklapper <aklap...@wikimedia.org>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
