jenkins-bot has submitted this change and it was merged. Change subject: Reorder x-wiki bundles to be after local notifications ......................................................................
Reorder x-wiki bundles to be after local notifications Bug: T127422 Change-Id: I81ae2e13612168a598c32f130a625eadc0325c8f --- M modules/viewmodel/mw.echo.dm.NotificationsModel.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/viewmodel/mw.echo.dm.NotificationsModel.js b/modules/viewmodel/mw.echo.dm.NotificationsModel.js index 196ef71..79f3715 100644 --- a/modules/viewmodel/mw.echo.dm.NotificationsModel.js +++ b/modules/viewmodel/mw.echo.dm.NotificationsModel.js @@ -71,6 +71,10 @@ return -1; // Unread items are always above read items } else if ( a.isRead() && !b.isRead() ) { return 1; + } else if ( !a.isForeign() && b.isForeign() ) { + return -1; + } else if ( a.isForeign() && !b.isForeign() ) { + return 1; } else { // Reverse sorting diff = Number( b.getTimestamp() ) - Number( a.getTimestamp() ); -- To view, visit https://gerrit.wikimedia.org/r/273518 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ae2e13612168a598c32f130a625eadc0325c8f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits