Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/273563
Change subject: Pass through deletion reason parameters to talk page notif templates as well ...................................................................... Pass through deletion reason parameters to talk page notif templates as well These were previously only passed to tag templates, but the talk page notif template for A10 on enwiki tries to use the {{{article}}} parameter, which breaks. Bug: T128024 Change-Id: I65c6b521bd27e61b1d1c08996fd80f4002a79965 --- M modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage refs/changes/63/273563/1 diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js index 34d56f9..e0c3169 100644 --- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js +++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js @@ -752,6 +752,7 @@ */ notifyUser: function ( count, key ) { var template, + paramsText = '', that = this; if ( count === 0 || !this.selectedTag[ key ] ) { @@ -759,8 +760,13 @@ } // use generic template for multiple deletion tag - template = ( count > 1 ) ? $.pageTriageDeletionTagsMultiple.talkpagenotiftpl : this.selectedTag[ key ].talkpagenotiftpl; - template = '{{subst:' + template + '|' + pageName + '}}'; + if ( count > 1 ) { + template = $.pageTriageDeletionTagsMultiple.talkpagenotiftpl; + } else { + template = this.selectedTag[ key ].talkpagenotiftpl; + paramsText = this.buildParams( this.selectedTag[ key ] ); + } + template = '{{subst:' + template + '|' + pageName + paramsText + '}}'; // Appending signature template += ' ~~~~'; -- To view, visit https://gerrit.wikimedia.org/r/273563 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I65c6b521bd27e61b1d1c08996fd80f4002a79965 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageTriage Gerrit-Branch: master Gerrit-Owner: Catrope <roan.katt...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits