Ricordisamoa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/273568

Change subject: TidyUpBug37714: Remove array dereferencing workaround
......................................................................

TidyUpBug37714: Remove array dereferencing workaround

Change-Id: Ic4d7876575cf60f31c85d9288a30fd7055b93376
---
M maintenance/tidyUpBug37714.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/273568/1

diff --git a/maintenance/tidyUpBug37714.php b/maintenance/tidyUpBug37714.php
index e9c006e..803d943 100644
--- a/maintenance/tidyUpBug37714.php
+++ b/maintenance/tidyUpBug37714.php
@@ -20,8 +20,8 @@
                );
 
                foreach ( $result as $row ) {
-                       $paramLines = explode( "\n", $row->log_params );
-                       $ids = explode( ',', $paramLines[0] ); // Array 
dereferencing is PHP >= 5.4 :(
+                       $paramLines = explode( "\n", $row->log_params )[0];
+                       $ids = explode( ',', $paramLines );
                        $result = $this->getDB( DB_SLAVE )->select( // Work out 
what log entries were changed here.
                                'logging',
                                'log_type',

-- 
To view, visit https://gerrit.wikimedia.org/r/273568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4d7876575cf60f31c85d9288a30fd7055b93376
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisa...@openmailbox.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to