Foxtrott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273574
Change subject: Add link to anon's user page; remove "Not logged in" and
"Create account"
......................................................................
Add link to anon's user page; remove "Not logged in" and "Create account"
Improve the personal tools:
* Remove the "Not logged in" text message. It is misleading. Being among the
personal tool links people click on it expecting it to have some function.
* Instead add a proper link "Anonymous user" to the IP user page.
* Remove the "Create account" link. It clutters the personal toolbar. The
functionlity is available via the "Log in" link.
Bug: T121793
Change-Id: I049d0671a7050585659fc8b9dcf21e0f92393bcf
---
M includes/skins/SkinTemplate.php
M languages/i18n/en.json
M languages/i18n/qqq.json
3 files changed, 8 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/74/273574/1
diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index 1328870..1cceb75 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -662,17 +662,18 @@
// No need to show Talk and Contributions to anons if
they can't contribute!
if ( User::groupHasPermission( '*', 'edit' ) ) {
- // Show the text "Not logged in"
- $personal_urls['anonuserpage'] = array(
- 'text' => $this->msg( 'notloggedin'
)->text()
- );
- // Because of caching, we can't link directly
to the IP talk and
+ // Because of caching, we can't link directly
to the IP user, talk and
// contributions pages. Instead we use the
special page shortcuts
// (which work correctly regardless of
caching). This means we can't
// determine whether these links are active or
not, but since major
// skins (MonoBook, Vector) don't use this
information, it's not a
// huge loss.
+ $personal_urls['anonuserpage'] = array(
+ 'text' => $this->msg( 'anonuserpage'
)->text(),
+ 'href' => self::makeSpecialUrlSubpage(
'Mypage', false ),
+ 'active' => false
+ );
$personal_urls['anontalk'] = array(
'text' => $this->msg( 'anontalk'
)->text(),
'href' => self::makeSpecialUrlSubpage(
'Mytalk', false ),
@@ -683,10 +684,6 @@
'href' => self::makeSpecialUrlSubpage(
'Mycontributions', false ),
'active' => false
);
- }
-
- if ( $this->getUser()->isAllowed( 'createaccount' ) &&
!$useCombinedLoginLink ) {
- $personal_urls['createaccount'] =
$createaccount_url;
}
$personal_urls['login'] = $login_url;
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index b278df6..fc296f6 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -143,6 +143,7 @@
"moredotdotdot": "More...",
"morenotlisted": "This list is not complete.",
"mypage": "Page",
+ "anonuserpage": "Anonymous user",
"mytalk": "Talk",
"anontalk": "Talk",
"navigation": "Navigation",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 038c67c..e74285a 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -319,6 +319,7 @@
"moredotdotdot": "Used as \"More...\" link for
{{msg-mw|pageinfo-transclusions}} field, in the \"templates used on this page\"
list.\n\nSimilar to {{msg-mw|morenotlisted}}.\n{{Identical|More...}}",
"morenotlisted": "An indication that more of a templates list is not
shown.\n\nUsed as \"More...\" link for {{msg-mw|pageinfo-templates}}
field.\n\nSimilar to {{msg-mw|moredotdotdot}}.",
"mypage": "A text for the link to the user's user page in the links at
the top of the page.\n{{Identical|Page}}",
+ "anonpage": "Same as {{msg-mw|mypage}} but used for non-logged-in
users.\nA text for the link to the IP user page in the links at the top of the
page.\n\nSee also:\n* {{msg-mw|Accesskey-pt-anonuserpage}}\n*
{{msg-mw|Tooltip-pt-anonuserpage}}\n{{Identical|Page}}",
"mytalk": "In the personal URLs page section - right upper
corner.\n\nUsed as link title in your personal toolbox.\n\nSee also:\n*
{{msg-mw|Mytalk}}\n* {{msg-mw|Accesskey-pt-mytalk}}\n*
{{msg-mw|Tooltip-pt-mytalk}}\n{{Identical|Talk}}",
"anontalk": "Same as {{msg-mw|mytalk}} but used for non-logged-in
users.\n{{Identical|Talk}}\n\nSee also:\n* {{msg-mw|Accesskey-pt-anontalk}}\n*
{{msg-mw|Tooltip-pt-anontalk}}",
"navigation": "This is shown as a section header in the sidebar of most
skins.\n\n{{Identical|Navigation}}",
--
To view, visit https://gerrit.wikimedia.org/r/273574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I049d0671a7050585659fc8b9dcf21e0f92393bcf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Foxtrott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
