Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/273711
Change subject: Don't use decodeURIComponent on Undefined
......................................................................
Don't use decodeURIComponent on Undefined
decodeURIComponent will return the string "undefined", which casts to
the boolean true. That means, that the talk overlay would add new discussions
to the title "Undefined" instead of the expected mw.config.get( 'wgPageName' ).
Fix this by check first, if the title data attribute is Undefined (which casts
to
the boolean false) and if not use decodeURIComponent.
Bug: T128273
Change-Id: I59dbbe02f25bf123ebe3cae947289c611a23b9dd
(cherry picked from commit deacd7de70e29ffaaf1875dd7782a663b8cf96fa)
---
M resources/skins.minerva.talk/init.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/11/273711/1
diff --git a/resources/skins.minerva.talk/init.js
b/resources/skins.minerva.talk/init.js
index cd2a39d..abc674b 100644
--- a/resources/skins.minerva.talk/init.js
+++ b/resources/skins.minerva.talk/init.js
@@ -4,7 +4,8 @@
user = M.require( 'mobile.user/user' ),
Button = M.require( 'mobile.startup/Button' ),
$talk = $( '.talk' ),
- title = decodeURIComponent( $talk.data( 'title' ) ) ||
mw.config.get( 'wgPageName' ),
+ title = $talk.data( 'title' ) && decodeURIComponent(
$talk.data( 'title' ) ) ||
+ mw.config.get( 'wgPageName' ),
page = M.getCurrentPage(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
skin = M.require( 'skins.minerva.scripts/skin' );
--
To view, visit https://gerrit.wikimedia.org/r/273711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59dbbe02f25bf123ebe3cae947289c611a23b9dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.27.0-wmf.14
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
