Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274376
Change subject: [BrowserTest] Fix `ve.init is undefined` and `ve.init.target is
undefined` error messages
......................................................................
[BrowserTest] Fix `ve.init is undefined` and `ve.init.target is undefined`
error messages
Looks like local browsers raise
Selenium::WebDriver::Error::JavascriptError while remote (Sauce Labs)
browsers raise Selenium::WebDriver::Error::UnknownError if a test tries
to use an element but VisualEditor is not loaded.
Bug: T126966
Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
---
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/76/274376/1
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 0917211..d3409ab 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -206,6 +206,7 @@
begin
browser.execute_script script
rescue Selenium::WebDriver::Error::JavascriptError => e
+ rescue Selenium::WebDriver::Error::UnknownError => e
else
e = nil
end
--
To view, visit https://gerrit.wikimedia.org/r/274376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89c8eaba996e95e7859084fe26e15befee9dce77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
