jenkins-bot has submitted this change and it was merged.
Change subject: Fix and add missing PHPDoc tags
......................................................................
Fix and add missing PHPDoc tags
Change-Id: Ia714c81a524d8619852f8a09d505722913b1bf9b
---
M includes/Html/HtmlTableBuilder.php
M tests/phpunit/Helper/JsonFileEntityLookup.php
M tests/phpunit/Html/HtmlTableBuilderTest.php
3 files changed, 15 insertions(+), 6 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Html/HtmlTableBuilder.php
b/includes/Html/HtmlTableBuilder.php
index 2123a33..1c4bf5f 100644
--- a/includes/Html/HtmlTableBuilder.php
+++ b/includes/Html/HtmlTableBuilder.php
@@ -31,6 +31,7 @@
/**
* @param array $headers
+ *
* @throws InvalidArgumentException
*/
public function __construct( $headers ) {
@@ -45,6 +46,8 @@
/**
* @param string|HtmlTableHeaderBuilder $header
+ *
+ * @throws InvalidArgumentException
*/
private function addHeader( $header ) {
if ( is_string( $header ) ) {
@@ -61,7 +64,7 @@
}
/**
- * @return HtmlTableHeaderBuilder
+ * @return HtmlTableHeaderBuilder[]
*/
public function getHeaders() {
return $this->headers;
@@ -85,6 +88,8 @@
* Adds row with specified cells to table.
*
* @param string[]|HtmlTableCellBuilder[] $cells
+ *
+ * @throws InvalidArgumentException
*/
public function appendRow( array $cells ) {
foreach ( $cells as $key => $cell ) {
@@ -102,6 +107,8 @@
* Adds rows with specified cells to table.
*
* @param array $rows
+ *
+ * @throws InvalidArgumentException
*/
public function appendRows( array $rows ) {
foreach ( $rows as $cells ) {
@@ -157,4 +164,5 @@
return $html;
}
-}
\ No newline at end of file
+
+}
diff --git a/tests/phpunit/Helper/JsonFileEntityLookup.php
b/tests/phpunit/Helper/JsonFileEntityLookup.php
index 8a1896e..fdb7022 100644
--- a/tests/phpunit/Helper/JsonFileEntityLookup.php
+++ b/tests/phpunit/Helper/JsonFileEntityLookup.php
@@ -38,7 +38,7 @@
'number' => 'DataValues\NumberValue',
'string' => 'DataValues\StringValue',
'unknown' => 'DataValues\UnknownValue',
- 'globecoordinate' =>
'DataValues\GlobeCoordinateValue',
+ 'globecoordinate' =>
'DataValues\Geo\Values\GlobeCoordinateValue',
'monolingualtext' =>
'DataValues\MonolingualTextValue',
'multilingualtext' =>
'DataValues\MultilingualTextValue',
'quantity' =>
'DataValues\QuantityValue',
diff --git a/tests/phpunit/Html/HtmlTableBuilderTest.php
b/tests/phpunit/Html/HtmlTableBuilderTest.php
index b35d480..84f677d 100644
--- a/tests/phpunit/Html/HtmlTableBuilderTest.php
+++ b/tests/phpunit/Html/HtmlTableBuilderTest.php
@@ -6,7 +6,6 @@
use WikibaseQuality\Html\HtmlTableCellBuilder;
use WikibaseQuality\Html\HtmlTableHeaderBuilder;
-
/**
* @covers WikibaseQuality\Html\HtmlTableBuilder
*
@@ -237,8 +236,9 @@
* Creates HtmlHeaderCell mock, which returns only the content when
calling HtmlHeaderCell::toHtml()
*
* @param string $content
+ * @param bool $isSortable
*
- * @return \PHPUnit_Framework_MockObject_MockObject
+ * @return HtmlTableHeaderBuilder
*/
private function getHtmlTableHeaderMock( $content, $isSortable = false
) {
$cellMock = $this
@@ -259,7 +259,7 @@
*
* @param string $content
*
- * @return \PHPUnit_Framework_MockObject_MockObject
+ * @return HtmlTableCellBuilder
*/
private function getHtmlTableCellMock( $content ) {
$cellMock = $this
@@ -273,4 +273,5 @@
return $cellMock;
}
+
}
--
To view, visit https://gerrit.wikimedia.org/r/274401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia714c81a524d8619852f8a09d505722913b1bf9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuality
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
