Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274499
Change subject: Education popup: Also handle clicks on dots
......................................................................
Education popup: Also handle clicks on dots
Bug: T128440
Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
---
M modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/99/274499/1
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js
index d52b086..e470123 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js
@@ -59,7 +59,11 @@
this.shownEducationPopup = false;
this.$pulsatingDot = $( '<div>' ).addClass( 've-ui-pulsatingDot' );
this.$stillDot = $( '<div>' ).addClass( 've-ui-stillDot' );
- $shield = $( '<div>' ).addClass( 've-ui-educationPopup-shield' ).on(
'click', function () {
+ $shield = $( '<div>' ).addClass( 've-ui-educationPopup-shield' );
+ this.$element
+ .addClass( 've-ui-educationPopup' )
+ .append( $shield, this.popup.$element, this.$stillDot,
this.$pulsatingDot );
+ this.$element.children().not( this.popup.$element ).on( 'click',
function () {
if ( !tool.shownEducationPopup ) {
if ( ve.init.target.openEducationPopupTool ) {
ve.init.target.openEducationPopupTool.popup.toggle( false );
@@ -78,9 +82,6 @@
$shield.remove();
}
} );
- this.$element
- .addClass( 've-ui-educationPopup' )
- .append( $shield, this.popup.$element, this.$stillDot,
this.$pulsatingDot );
setTimeout( function () {
var radius = tool.$pulsatingDot.width() / 2;
--
To view, visit https://gerrit.wikimedia.org/r/274499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25728cf3dd3462cb1a13476fe45d7fc3755429dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
