Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/275143
Change subject: Hygiene: Remove srcset stripping in MobileFrontend ...................................................................... Hygiene: Remove srcset stripping in MobileFrontend This can be and is configured via $wgResponsiveImages and EnterMobileMode hook. Thanks for @krinkle for pointing this out: https://github.com/wikimedia/ operations-mediawiki-config/blob/ 1da33e4cdcd3144d3ca63469750361deee90ee15/wmf-config/mobile.php#L73 Change-Id: Ifb7c4673ce6bb2a60ed8086be5d85283711b5e60 --- M extension.json M includes/MobileFrontend.hooks.php 2 files changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/43/275143/1 diff --git a/extension.json b/extension.json index 9ee40ae..a66bc25 100644 --- a/extension.json +++ b/extension.json @@ -1906,9 +1906,6 @@ "SkinPreloadExistence": [ "MobileFrontendHooks::onSkinPreloadExistence" ], - "ThumbnailBeforeProduceHTML": [ - "MobileFrontendHooks::onThumbnailBeforeProduceHTML" - ], "PageRenderingHash": [ "MobileFrontendHooks::onPageRenderingHash" ], diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 61d8ef9..6bf82cb 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -1262,19 +1262,6 @@ } /** - * Omit srcset attributes from thumbnail image tags, to conserve bandwidth. - * - * @param ThumbnailImage $thumbnail - * @param array &$attribs - * @param array &$linkAttribs - */ - public static function onThumbnailBeforeProduceHTML( $thumbnail, &$attribs, &$linkAttribs ) { - if ( MobileContext::singleton()->shouldDisplayMobileView() ) { - unset( $attribs['srcset'] ); - } - } - - /** * LoginFormValidErrorMessages hook handler to promote MF specific error message be valid. * * @param array $messages Array of already added messages -- To view, visit https://gerrit.wikimedia.org/r/275143 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb7c4673ce6bb2a60ed8086be5d85283711b5e60 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
