jenkins-bot has submitted this change and it was merged.
Change subject: Don't list dynamic sidebar groups twice
......................................................................
Don't list dynamic sidebar groups twice
Bug: T128404
Change-Id: I41fe1c06178d40d16e380094d86dad6ae20efcc3
---
M nova/OpenStackNovaUser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Andrew Bogott: Looks good to me, but someone else must approve
Legoktm: Looks good to me, approved
Samtar: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/nova/OpenStackNovaUser.php b/nova/OpenStackNovaUser.php
index a67fbb2..b3682ee 100644
--- a/nova/OpenStackNovaUser.php
+++ b/nova/OpenStackNovaUser.php
@@ -570,7 +570,7 @@
$user = new OpenStackNovaUser();
$roles = $user->getRoles();
}
- $groups = array_merge( $groups, $roles );
+ $groups = array_unique( array_merge( $groups, $roles )
);
}
return true;
--
To view, visit https://gerrit.wikimedia.org/r/274079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41fe1c06178d40d16e380094d86dad6ae20efcc3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Samtar <[email protected]>
Gerrit-Reviewer: Tim Landscheidt <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
