Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/275595
Change subject: End A/B test of morelike "opening_text" query.
......................................................................
End A/B test of morelike "opening_text" query.
Change-Id: I372c46a03910125edac3d99caf295e7554eab323
---
M app/src/main/java/org/wikipedia/WikipediaApp.java
M app/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
M app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
M app/src/main/java/org/wikipedia/settings/Prefs.java
M app/src/main/res/values/preference_keys.xml
M app/src/main/res/xml/developer_preferences.xml
6 files changed, 1 insertion(+), 35 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/95/275595/1
diff --git a/app/src/main/java/org/wikipedia/WikipediaApp.java
b/app/src/main/java/org/wikipedia/WikipediaApp.java
index 099761f..bfc39a9 100644
--- a/app/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/app/src/main/java/org/wikipedia/WikipediaApp.java
@@ -407,17 +407,6 @@
return EVENT_LOG_TESTING_ID;
}
- public boolean isFeatureReadMoreSearchOpeningTextEnabled() {
- boolean enabled;
- if (Prefs.hasFeatureReadMoreSearchOpeningText()) {
- enabled = Prefs.isFeatureReadMoreSearchOpeningTextEnabled();
- } else {
- enabled = new Random().nextInt(2) == 0;
- Prefs.setFeatureReadMoreSearchOpeningTextEnabled(enabled);
- }
- return enabled;
- }
-
public boolean isFeatureSearchAutoCompleteEnabled() {
// Only enable for pre-production builds/releases, since the feature
itself is in beta.
if (ReleaseUtil.isProdRelease()) {
diff --git
a/app/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
b/app/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
index 8c41e4c..c820a11 100644
--- a/app/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
+++ b/app/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
@@ -14,14 +14,13 @@
private static final int REV_ID = 15302212;
private static final int READ_MORE_SOURCE_FULL_TEXT = 0;
private static final int READ_MORE_SOURCE_MORELIKE = 1;
- private static final int READ_MORE_SOURCE_OPENING_TEXT = 2;
private int readMoreSource;
private long latency;
public SuggestedPagesFunnel(WikipediaApp app) {
super(app, SCHEMA_NAME, REV_ID, Funnel.SAMPLE_LOG_100);
- this.readMoreSource = app.isFeatureReadMoreSearchOpeningTextEnabled()
? READ_MORE_SOURCE_OPENING_TEXT : READ_MORE_SOURCE_MORELIKE;
+ this.readMoreSource = READ_MORE_SOURCE_MORELIKE;
}
@Override
diff --git a/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
b/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
index 95693af..eb7f778 100644
--- a/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
+++ b/app/src/main/java/org/wikipedia/search/FullSearchArticlesTask.java
@@ -64,11 +64,6 @@
.param("piprop", "thumbnail") // for thumbnail URLs
.param("pithumbsize", Integer.toString(thumbSize))
.param("pilimit", maxResultsString);
- if
(WikipediaApp.getInstance().isFeatureReadMoreSearchOpeningTextEnabled()) {
- req.param("cirrusMltUseFields", "yes")
- .param("cirrusMltFields", "opening_text")
- .param("cirrusBoostLinks", "no");
- }
if (continueOffset != null) {
req.param("continue", continueOffset.cont);
if (continueOffset.gsroffset > 0) {
diff --git a/app/src/main/java/org/wikipedia/settings/Prefs.java
b/app/src/main/java/org/wikipedia/settings/Prefs.java
index e6a01dd..94ca736 100644
--- a/app/src/main/java/org/wikipedia/settings/Prefs.java
+++ b/app/src/main/java/org/wikipedia/settings/Prefs.java
@@ -349,18 +349,6 @@
setBoolean(R.string.preference_key_share_tutorial_enabled, enabled);
}
- public static boolean isFeatureReadMoreSearchOpeningTextEnabled() {
- return
getBoolean(R.string.preference_key_feature_read_more_search_opening_text, true);
- }
-
- public static void setFeatureReadMoreSearchOpeningTextEnabled(boolean
enabled) {
-
setBoolean(R.string.preference_key_feature_read_more_search_opening_text,
enabled);
- }
-
- public static boolean hasFeatureReadMoreSearchOpeningText() {
- return
contains(R.string.preference_key_feature_read_more_search_opening_text);
- }
-
public static boolean isFeatureSearchAutoCompleteEnabled() {
return getBoolean(R.string.preference_key_feature_search_autocomplete,
true);
}
diff --git a/app/src/main/res/values/preference_keys.xml
b/app/src/main/res/values/preference_keys.xml
index 83e7689..53e65ef 100644
--- a/app/src/main/res/values/preference_keys.xml
+++ b/app/src/main/res/values/preference_keys.xml
@@ -16,7 +16,6 @@
<string name="preference_key_language_mru">languageMru</string>
<string
name="preference_key_select_text_tutorial_enabled">selectTextTutorialEnabled</string>
<string
name="preference_key_share_tutorial_enabled">shareTutorialEnabled</string>
- <string
name="preference_key_feature_read_more_search_opening_text">readMoreSearchOpeningText</string>
<string
name="preference_key_feature_search_autocomplete">searchAutoComplete</string>
<string
name="preference_key_toc_tutorial_enabled">tocTutorialEnabled</string>
<string name="preference_key_show_images">showImages</string>
diff --git a/app/src/main/res/xml/developer_preferences.xml
b/app/src/main/res/xml/developer_preferences.xml
index 39c5fab..8c16e17 100644
--- a/app/src/main/res/xml/developer_preferences.xml
+++ b/app/src/main/res/xml/developer_preferences.xml
@@ -4,10 +4,6 @@
<PreferenceCategory
android:title="@string/preferences_developer_feature_testing_heading">
<CheckBoxPreference
-
android:key="@string/preference_key_feature_read_more_search_opening_text"
-
android:title="@string/preference_key_feature_read_more_search_opening_text" />
-
- <CheckBoxPreference
android:key="@string/preference_key_feature_search_autocomplete"
android:title="@string/preference_key_feature_search_autocomplete"/>
--
To view, visit https://gerrit.wikimedia.org/r/275595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I372c46a03910125edac3d99caf295e7554eab323
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
