Andrew Bogott has submitted this change and it was merged. Change subject: nodepool: rotate daily at midnight ......................................................................
nodepool: rotate daily at midnight logging.handlers.TimedRotatingFileHandler would rotate daily based on the time creation of the previous log file. That ends up to be sometime in the day and for image creation log (which we do once per day) kicks in right in the middle of image creation. Instead, rotate daily logs at midnight local time (which is UTC on Wikimedia servers). Reference: https://docs.python.org/2/library/logging.handlers.html#timedrotatingfilehandler Change-Id: Ia10b37226f15567f13c9de61212bffdaf7f786e0 --- M modules/nodepool/files/logging.conf 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Andrew Bogott: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/nodepool/files/logging.conf b/modules/nodepool/files/logging.conf index 8b762a6..25b622f 100644 --- a/modules/nodepool/files/logging.conf +++ b/modules/nodepool/files/logging.conf @@ -54,13 +54,13 @@ level=INFO class=logging.handlers.TimedRotatingFileHandler formatter=simple -args=('/var/log/nodepool/nodepool.log', 'D', 1, 15,) +args=('/var/log/nodepool/nodepool.log', 'midnight', 1, 15,) [handler_image] level=INFO class=logging.handlers.TimedRotatingFileHandler formatter=simple -args=('/var/log/nodepool/image.log', 'D', 1, 15,) +args=('/var/log/nodepool/image.log', 'midnight', 1, 15,) ### Formatters ###################################### -- To view, visit https://gerrit.wikimedia.org/r/269213 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia10b37226f15567f13c9de61212bffdaf7f786e0 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Andrew Bogott <[email protected]> Gerrit-Reviewer: Chasemp <[email protected]> Gerrit-Reviewer: Filippo Giunchedi <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
