jenkins-bot has submitted this change and it was merged.
Change subject: Don't set up custom groups in extensions
......................................................................
Don't set up custom groups in extensions
Particularly from extension.json, which makes it impossible
to unset from config
See T105676
Change-Id: I678326ea9c50525304e6d0e8ad564d5237c4dc90
---
M CodeReview.php
M extension.json
M i18n/en.json
M i18n/qqq.json
4 files changed, 0 insertions(+), 15 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CodeReview.php b/CodeReview.php
index 0b49a89..74f3c5c 100644
--- a/CodeReview.php
+++ b/CodeReview.php
@@ -153,8 +153,6 @@
$wgGroupPermissions['user']['codereview-signoff'] = true;
$wgGroupPermissions['user']['codereview-associate'] = true;
-$wgGroupPermissions['svnadmins']['repoadmin'] = true;
-
/******** CONFIGURATION SETTINGS ********/
// If you can't directly access the remote SVN repo, you can set this
diff --git a/extension.json b/extension.json
index 3e5be8f..3e35366 100644
--- a/extension.json
+++ b/extension.json
@@ -133,9 +133,6 @@
"codereview-link-user": true,
"codereview-signoff": true,
"codereview-associate": true
- },
- "svnadmins": {
- "repoadmin": true
}
},
"AvailableRights": [
diff --git a/i18n/en.json b/i18n/en.json
index 42d1249..04de7ee 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -189,11 +189,6 @@
"action-codereview-link-user": "link authors to wiki users",
"action-codereview-associate": "manage revision associations",
"action-codereview-review-own": "mark your own revisions as
\"{{int:code-status-ok}}\" or \"{{int:code-status-resolved}}\"",
- "group-svnadmins": "SVN admins",
- "group-svnadmins-member": "{{GENDER:$1|SVN admin}}",
- "grouppage-svnadmins": "{{ns:project}}:SVN admins",
- "group-svnadmins.css": "/* CSS placed here will affect SVN admins only
*/",
- "group-svnadmins.js": "/* JS placed here will affect SVN admins only
*/",
"apihelp-codediff-description": "Fetch formatted diff from CodeReview's
backing revision control system.",
"apihelp-codediff-param-repo": "Name of repository to look at.",
"apihelp-codediff-param-rev": "Revision ID to fetch diff of.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 772aadd..46aff48 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -215,11 +215,6 @@
"action-codereview-link-user": "{{doc-action|codereview-link-user}}",
"action-codereview-associate": "{{doc-action|codereview-associate}}",
"action-codereview-review-own":
"{{doc-action|codereview-review-own}}\nRefers to {{msg-mw|Code-status-ok}} and
{{msg-mw|Code-status-resolved}}.",
- "group-svnadmins": "{{doc-group|svnadmins}}",
- "group-svnadmins-member": "{{doc-group|svnadmins|member}}",
- "grouppage-svnadmins": "{{doc-group|svnadmins|page}}",
- "group-svnadmins.css": "{{doc-group|svnadmins|css}}",
- "group-svnadmins.js": "{{doc-group|svnadmins|js}}",
"apihelp-codediff-description": "{{doc-apihelp-description|codediff}}",
"apihelp-codediff-param-repo": "{{doc-apihelp-param|codediff|repo}}",
"apihelp-codediff-param-rev": "{{doc-apihelp-param|codediff|rev}}",
--
To view, visit https://gerrit.wikimedia.org/r/227361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I678326ea9c50525304e6d0e8ad564d5237c4dc90
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
