Lethexie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/275796
Change subject: fixed the bug of SpaceyParenthesisSniff cann't fix $a->foo( $b
) and $a->foo( $b )
......................................................................
fixed the bug of SpaceyParenthesisSniff cann't fix $a->foo( $b ) and $a->foo(
$b )
Change-Id: I39cdf331f6e117812c2245425dfecc92efaef836
---
M MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer
refs/changes/96/275796/1
diff --git a/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
b/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
index 92cd9d9..34d4652 100644
--- a/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
+++ b/MediaWiki/Sniffs/WhiteSpace/SpaceyParenthesisSniff.php
@@ -83,7 +83,13 @@
'SingleSpaceAfterOpenParenthesis'
);
if ( $fix === true ) {
- $phpcsFile->fixer->addContent( $stackPtr, ' ' );
+ if ( $nextToken['code'] === T_WHITESPACE
+ && strpos( $nextToken['content'], "\n"
) === false
+ && $nextToken['content'] != ' ' ) {
+ $phpcsFile->fixer->replaceToken(
$stackPtr + 1, ' ' );
+ } else {
+ $phpcsFile->fixer->addContent(
$stackPtr, ' ' );
+ }
}
}
}
@@ -122,7 +128,7 @@
'SingleSpaceBeforeCloseParenthesis'
);
if ( $fix === true ) {
- $phpcsFile->fixer->addContentBefore( $stackPtr, ' ' );
+ $phpcsFile->fixer->replaceToken( $stackPtr - 1, ' ');
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/275796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39cdf331f6e117812c2245425dfecc92efaef836
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Lethexie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
