OliverKeyes has submitted this change and it was merged.

Change subject: Sub-test filtering
......................................................................


Sub-test filtering

Changes the LDN query to filter out events from A/B tests.

Change-Id: I72dc28dc976c417d09f53ced16edb0ff7cedd5b4
---
M search/LDN.R
1 file changed, 4 insertions(+), 12 deletions(-)

Approvals:
  OliverKeyes: Verified; Looks good to me, approved



diff --git a/search/LDN.R b/search/LDN.R
index 55e51e5..2172eba 100644
--- a/search/LDN.R
+++ b/search/LDN.R
@@ -9,19 +9,11 @@
   checkins <- c(0, 10, 20, 30, 40, 50, 60, 90, 120, 150, 180, 210, 240, 300, 
360, 420)
   # ^ this will be used for figuring out the interval bounds for each check-in
   
-  # Ensure we have a date:
-  if(is.null(date)) {
-    date <- Sys.Date() - 1
-  }
-  
-  # Decide which table to query depending on the date:
-  if ( date < as.Date('2015-09-02') ) {
-    warning('No data exists prior to 09/02/2015')
-    return(invisible())
-  }
-  
   # Get data and format:
-  data <- wmf::build_query(fields = "SELECT * ", date = date, table = table)
+  data <- wmf::build_query(fields = "SELECT * ",
+                           date = date,
+                           table = table,
+                           conditionals = "event_subTest IS NULL")
   data <- data.table::as.data.table(data)
   data$timestamp <- lubridate::ymd_hms(data$timestamp)
   

-- 
To view, visit https://gerrit.wikimedia.org/r/276359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72dc28dc976c417d09f53ced16edb0ff7cedd5b4
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: Bearloga <mpo...@wikimedia.org>
Gerrit-Reviewer: Bearloga <mpo...@wikimedia.org>
Gerrit-Reviewer: OliverKeyes <oke...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to