jenkins-bot has submitted this change and it was merged.
Change subject: Add jshint to npm
......................................................................
Add jshint to npm
Change-Id: I97a73883aa44ca2fbb18b30e6a8cd9f7691d31ac
---
A .jscsrc
M .jshintignore
M .jshintrc
M Gruntfile.js
M package.json
5 files changed, 30 insertions(+), 23 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
new file mode 100644
index 0000000..9d22e3f
--- /dev/null
+++ b/.jscsrc
@@ -0,0 +1,3 @@
+{
+ "preset": "wikimedia"
+}
diff --git a/.jshintignore b/.jshintignore
index 237c307..b8498ef 100644
--- a/.jshintignore
+++ b/.jshintignore
@@ -1,2 +1 @@
-# Blank file to prevent jshint from walking up directory chain and
-# finding core's .jshintignore file, which excludes extensions
+node_mdoules/**
diff --git a/.jshintrc b/.jshintrc
index c6a55a0..b402baa 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -1,34 +1,28 @@
{
- "predef": [
- "mediaWiki",
- "jQuery",
- "QUnit"
- ],
+ // Enforcing
"es3": true,
"bitwise": true,
- "camelcase": true,
- "curly": true,
"eqeqeq": true,
- "forin": false,
- "immed": true,
- "latedef": true,
- "newcap": true,
+ "freeze": true,
+ "latedef": "nofunc",
+ "laxbreak": true,
+ "multistr": true,
"noarg": true,
- "noempty": true,
"nonew": true,
- "quotmark": "single",
- "regexp": false,
"undef": true,
"unused": true,
"strict": false,
- "trailing": true,
- "laxbreak": true,
- "smarttabs": true,
- "multistr": true,
+ // Relaxing
+ "es5": false,
+ // Environment
"browser": true,
+ "jquery": true,
- "nomen": true,
- "onevar": true
+ "globals": {
+ "mediaWiki": false,
+ "QUnit": false,
+ "JSON": true
+ }
}
diff --git a/Gruntfile.js b/Gruntfile.js
index 9c56558..1c3f452 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,9 +1,19 @@
/*jshint node:true */
module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.initConfig( {
+ jshint: {
+ options: {
+ jshintrc: true
+ },
+ all: [
+ '**/*.js',
+ '!node_modules/**'
+ ]
+ },
banana: {
all: 'i18n/'
},
@@ -15,6 +25,6 @@
}
} );
- grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
};
diff --git a/package.json b/package.json
index 72eb4aa..2b3860e 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,7 @@
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
"grunt-banana-checker": "0.4.0",
+ "grunt-contrib-jshint": "1.0.0",
"grunt-jsonlint": "1.0.7"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/276135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97a73883aa44ca2fbb18b30e6a8cd9f7691d31ac
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: Swalling <steven.wall...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
