jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: do not allow bad code to enum conversion
......................................................................
Hygiene: do not allow bad code to enum conversion
Although the app could likely run with a default value, perhaps it is
better to fail early if the conversion of an invalid status code is
attempted.
Change-Id: I34e3a1e04107ef9bc3a7d80682b6286c579edbdc
---
M app/src/main/java/org/wikipedia/database/sync/SyncStatus.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Mholloway: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/database/sync/SyncStatus.java
b/app/src/main/java/org/wikipedia/database/sync/SyncStatus.java
index 7b111e9..78f95d9 100644
--- a/app/src/main/java/org/wikipedia/database/sync/SyncStatus.java
+++ b/app/src/main/java/org/wikipedia/database/sync/SyncStatus.java
@@ -1,5 +1,6 @@
package org.wikipedia.database.sync;
+import android.support.annotation.NonNull;
import android.util.SparseArray;
public enum SyncStatus {
@@ -22,8 +23,13 @@
private final int code;
+ @NonNull
public static SyncStatus of(int code) {
- return CODE_TO_ENUM.get(code);
+ SyncStatus status = CODE_TO_ENUM.get(code);
+ if (status == null) {
+ throw new IllegalArgumentException("code=" + code);
+ }
+ return status;
}
public int code() {
--
To view, visit https://gerrit.wikimedia.org/r/276669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34e3a1e04107ef9bc3a7d80682b6286c579edbdc
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
