jenkins-bot has submitted this change and it was merged.
Change subject: thank-you-edit: Cast counts as integers before comparing
......................................................................
thank-you-edit: Cast counts as integers before comparing
Because somehow we're ending up with 100 !== 100 in the logs.
Change-Id: I9c24b5dca3fea7d52fc0e0a52e53702385eb0fb1
---
M Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Hooks.php b/Hooks.php
index 4112c47..5015b0c 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -466,7 +466,7 @@
// Fresh User object
$user = User::newFromId( $id );
$userEditCount = $user->getEditCount();
- if ( $userEditCount !== $thresholdCount
) {
+ if ( (int)$userEditCount !==
(int)$thresholdCount ) {
// Race condition with multiple
simultaneous requests, skip
LoggerFactory::getInstance(
'Echo' )->debug(
'thank-you-edit race
condition detected: {user} (id: {id}) should ' .
--
To view, visit https://gerrit.wikimedia.org/r/276793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c24b5dca3fea7d52fc0e0a52e53702385eb0fb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
