Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276823
Change subject: Add npm entry point
......................................................................
Add npm entry point
Change-Id: I73cf032c63fd07b092ffeadf2fe2fbaeaab23010
---
A .jshintignore
M .jshintrc
A Gruntfile.js
A package.json
M skin/openid.js
5 files changed, 52 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenID
refs/changes/23/276823/1
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..3c3629e
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.jshintrc b/.jshintrc
index e5e77e0..04c3a97 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -2,19 +2,22 @@
// Enforcing
"bitwise": true,
"eqeqeq": true,
- "es3": true,
"freeze": true,
- "latedef": true,
+ "latedef": "nofunc",
"noarg": true,
"nonew": true,
"undef": true,
"unused": true,
+ "strict": false,
+
+ // Relaxing
+ "es5": false,
// Environment
"browser": true,
+ "jquery": true,
"globals": {
- "$": false,
- "mw": false
+ "mediaWiki": false
}
}
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..36b6671
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,30 @@
+/*jshint node:true */
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-contrib-jshint' );
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ grunt.initConfig( {
+ jshint: {
+ options: {
+ jshintrc: true
+ },
+ all: [
+ '**/*.js',
+ '!node_modules/**'
+ ]
+ },
+ banana: {
+ all: 'i18n/'
+ },
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..ec97d7b
--- /dev/null
+++ b/package.json
@@ -0,0 +1,12 @@
+{
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "0.4.5",
+ "grunt-cli": "0.1.13",
+ "grunt-banana-checker": "0.4.0",
+ "grunt-contrib-jshint": "1.0.0",
+ "grunt-jsonlint": "1.0.7"
+ }
+}
diff --git a/skin/openid.js b/skin/openid.js
index 4dac490..c4bafa9 100644
--- a/skin/openid.js
+++ b/skin/openid.js
@@ -1,4 +1,4 @@
-(function () {
+( function ( $, mw ) {
var conf = mw.config.get([
'wgCookiePrefix',
'wgScript'
@@ -63,4 +63,4 @@
};
$( document ).ready( openid.init );
-}() );
+}( jQuery, mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/276823
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73cf032c63fd07b092ffeadf2fe2fbaeaab23010
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenID
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
